color: emit logical border side and axis colours#161
Merged
Conversation
border-y/s/e-<colour> produced nothing: the block axis and the inline start/end edges had no border colour setter, while border-x already mapped to border-inline-color. Wire Bs_y to border-block-color and Bs_s/Bs_e to border-inline-start-color/border-inline-end-color. Depends on cascade's Css.border_block_color (already added).
samoht
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
border-y-<color>produced nothing where Tailwind emitsborder-block-color: var(--color-*), because the block axis had no cascade setter;border-x-<color>already mapped toborder-inline-color. This wires the block-axis side (Bs_y) toCss.border_block_color, matching the reference.Depends on cascade adding
Css.border_block_color(samoht/cascade#197); CI stays red until that lands and is pinned.