Fixes ANTLR visibility method modifiers and static class handling#37
Merged
sampottinger merged 3 commits intomasterfrom Apr 5, 2019
Merged
Fixes ANTLR visibility method modifiers and static class handling#37sampottinger merged 3 commits intomasterfrom
sampottinger merged 3 commits intomasterfrom
Conversation
For consistency with prior processing, disallow use of the default visbility and instead prepend public modifier if no modifier is given. In response to @dzaima.
sampottinger
changed the title
sampottinger
added a commit
that referenced
this pull request
Apr 6, 2019
There were some issues related to public modifier injection that were introduced by #37, causing a large number of sketches to fail. This impacts #15 and does not impact but is related to processing#5753. To prevent regressions, also introduces JDT based tests to ensure edits are valid.
This was referenced Apr 6, 2019
sampottinger
added a commit
that referenced
this pull request
Apr 6, 2019
[antlr branch] Fix issues related to #37.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ANTLR static mode determination as well as changes visibility method modifiers. Specifically, for consistency with prior processing, disallow use of the default visibility and instead prepend public modifier if no modifier is given.