Broke out the static variables so that they can be used separately.#960
Broke out the static variables so that they can be used separately.#960eitanbanks merged 1 commit intomasterfrom
Conversation
|
@eitanbanks 👍 to merge when tests pass, but can you update the commit name and comment when you merge so it's clear what constants are being split out. |
7fd89b9 to
318a69b
Compare
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==============================================
+ Coverage 65.57% 65.573% +0.003%
+ Complexity 7376 7375 -1
==============================================
Files 528 528
Lines 31981 31981
Branches 5467 5467
==============================================
+ Hits 20970 20971 +1
+ Misses 8868 8866 -2
- Partials 2143 2144 +1
|
| public static final String VCF_EXTENSION = ".vcf"; | ||
| public static final String BCF_EXTENSION = ".bcf"; | ||
| public static final String COMPRESSED_VCF_EXTENSION = ".vcf.gz"; | ||
| public static final String[] VCF_EXTENSIONS = new String[] {VCF_EXTENSION, COMPRESSED_VCF_EXTENSION, BCF_EXTENSION}; |
There was a problem hiding this comment.
You don't need new String[] when you're using an array literal as an initializer. You can write it like this:
public static final String[] VCF_EXTENSIONS = {VCF_EXTENSION, COMPRESSED_VCF_EXTENSION, BCF_EXTENSION};
There was a problem hiding this comment.
Bah, I was just copying what was already there...
Alright, fine.
| @@ -87,7 +87,10 @@ public class IOUtil { | |||
| public static final long FIVE_GBS = 5 * ONE_GB; | |||
|
|
|||
| /** Possible extensions for VCF files and related formats. */ | |||
There was a problem hiding this comment.
This only applies to the field VCF_EXTENSION. Maybe it should be moved down to the line before VCF_EXTENSIONS. And you could add javadocs for the other new public fields.
|
|
||
| /** Possible extensions for VCF files and related formats. */ | ||
| public static final String[] VCF_EXTENSIONS = new String[] {".vcf", ".vcf.gz", ".bcf"}; | ||
| public static final String VCF_EXTENSION = ".vcf"; |
There was a problem hiding this comment.
Below I see fields named XXX_FILE_EXTENSION so the names here aren't consistent with them. I'm not sure how important consistency is in this file.
318a69b to
03e8eaa
Compare
Description
I want to use the individual constants outside of the list, so need them broken out.
Checklist