Closed
Conversation
The keys used to sign MSYS package have changed, so we have to update the key store first. The next problem is that newer MSYS packages are compressed with zstd, but the installed pacman cannot handle these. We need to explicitly update pacman first. Then finally we can install our build system. Note none of this is strictly necessary. The alternative solution is to comment out all pacman updates as the base image has sufficient compilers and libraries to build and pass the test harness. The main difference is the lack of libcurl, which then means we don't test compilation of the components that depend on it. We don't test these anyway, but it's useful to know they build at least. However if we hit problems in the future due to the explicit path of those key files then that's a viable temporary workaround. (It may be that AppVeyor also updates their base image at some point, in which case the key shenanigans can be deleted.)
Member
|
appveyor/ci#3513 suggests switching to the I've tested it in my branch https://github.com/daviesrob/htslib/tree/appveyor_img, and managed to get a successful build. |
Contributor
Author
|
Ah I didn't realise there were newer images to choose from. :-) Yes I prefer that solution. Can we get this fixed soon please? It's a right PITA at the moment. |
Member
|
I turned my branch into #1172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keys used to sign MSYS package have changed, so we have to update the key store first.
The next problem is that newer MSYS packages are compressed with zstd, but the installed pacman cannot handle these. We eed to explicitly update pacman first.
Then finally we can install our build system.
Note none of this is strictly necessary. The alternative solution is to comment out all pacman updates as the base image has sufficient compilers and libraries to build and pass the test harness.
The main difference is the lack of libcurl, which then means we don't test compilation of the components that depend on it. We don't test these anyway, but it's useful to know they build at least. However if we hit problems in the future due to the explicit path of those key files then that's a viable temporary workaround.
(It may be that AppVeyor also updates their base image at some point, in which case the key shenanigans can be deleted.)