Remove CRAM v4.0 support.#2020
Merged
Merged
Conversation
The reasoning for this is that it is highly complex and has had a number of security issues due to insufficient stress testing. Given the likelihood of CRAM4 ever seeing the light of day, it makes no sense to expose users to the risk of future bugs in this code without any practical benefit. There are some good ideas still in CRAM v4, but the community support just wasn't there and it's languished as an experimental format for years. Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
Member
|
Rebased... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasoning for this is that it is highly complex and has had a number of security issues due to insufficient stress testing. Given the likelihood of CRAM4 ever seeing the light of day, it makes no sense to expose users to the risk of future bugs in this code without any practical benefit.
There are some good ideas still in CRAM v4, but the community support just wasn't there and it's languished as an experimental format for years.