Add NULL checks to sam_hdr_read(), sam_hdr_write(); add checks to test/sam.c copy_check_alignment()#730
Merged
Merged
Conversation
Catch problems like sam_open() and sam_read1() failing. Prevents a seg fault if sam_open() fails on either the input or output file. Fixes samtools#728 (A SEGV signal occurred when running program sam in test directory).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for NULL
fpinsam_hdr_read(),sam_hdr_write()Add more tests for failure in copy_check_alignment()
Catch problems like sam_open() and sam_read1() failing. Prevents a seg fault if sam_open() fails on either the input or output file. #728 triggered this by running
./samin thetestdirectory instead of./test/samin the base directory.Fixes #728