New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mutable hash maps no longer expose elemEquals/elemHashCode extension point #11370

Open
retronym opened this Issue Jun 25, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@retronym
Copy link
Member

retronym commented Jun 25, 2018

This is a consequence of the change to compose HashTable rather than extend it.

If this is an intentional breaking change, we should go a bit further and inline calls to elemEquals and elemHashCode with calls to == and ##.

@retronym retronym changed the title New mutable hash maps no longer expose elemHashCode extension point New mutable hash maps no longer expose elemEquals/elemHashCode extension point Jun 25, 2018

@julienrf

This comment has been minimized.

Copy link

julienrf commented Jun 25, 2018

@retronym Do you recommend going back to inheritance?

@retronym

This comment has been minimized.

Copy link
Member Author

retronym commented Jun 26, 2018

@julienrf I sort of like the composition approach, but it isn't backwards compatible as it stands. Not sure how often this extension point is used in the wild. If we don't offer it, the workaround is for users to wrap their keys.

@adriaanm adriaanm transferred this issue from scala/scala-dev Jan 16, 2019

@SethTisue SethTisue added this to the 2.13.0-RC1 milestone Jan 16, 2019

@SethTisue SethTisue assigned szeiger and unassigned julienrf Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment