Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolboxes don't reset reporters after parser errors #5942

Closed
scabug opened this issue Jun 18, 2012 · 4 comments
Closed

toolboxes don't reset reporters after parser errors #5942

scabug opened this issue Jun 18, 2012 · 4 comments
Assignees
Milestone

Comments

@scabug
Copy link

@scabug scabug commented Jun 18, 2012

ToolBox potentially has a bug in the implementation of parseExpr. A call with a string containing a syntax error, produces a ToolBoxError. A subsequent call with a string containing correct code results in the same error:

scala> val tb = m.mkToolBox() 
tb: scala.tools.reflect.ToolBox[reflect.runtime.universe.type] = scala.tools.reflect.ToolBoxFactory$ToolBoxImpl@1f521f12 

scala> tb.parseExpr("def x = {}") // works fine 
res34: tb.u.Tree = def x = () 

scala> tb.parseExpr("def x = {") 
scala.tools.reflect.ToolBoxError: reflective compilation has failed: 

'}' expected but eof found. 
<strack-trace> 

scala> tb.parseExpr("def x = {}") // doesn't work any more 
scala.tools.reflect.ToolBoxError: reflective compilation has failed: 

'}' expected but eof found. 
<strack-trace> 
@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Jun 18, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5942?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0

@scabug

This comment has been minimized.

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Sep 17, 2012

@scabug

This comment has been minimized.

Copy link
Author

@scabug scabug commented Sep 18, 2012

@scabug scabug closed this Sep 18, 2012
@scabug scabug added this to the 2.10.0-M7 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.