Add some more examples of opaque types. #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still wanted to write more, but here's what I have at this moment.
jvican
reviewed
Oct 24, 2017
Member
jvican
left a comment
jvican
left a comment
There was a problem hiding this comment.
All these look very well thought out.
Do we have any example showing how we would use opaque types that have type bounds?
|
|
||
| ```scala | ||
| package object prob { | ||
| opaque type Probability = Double |
| ### Fix-point type | ||
|
|
||
| ```scala | ||
| package object fixed { |
Member
|
My updates: I had a read of http://cr.openjdk.java.net/~jrose/values/shady-values.html and I have nice observations to make on the differences between value types and opaque types. I'll follow up with a writeup of these! |
Member
|
We can wait and add updates in this PR before next SIP meeting (in November), or merge this right away and follow up in different PRs. What do you think it's best @non? |
Contributor
Author
|
I just added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still wanted to write more, but here's what I have at this moment.
@jvican I'm going to try to push some more change to this branch but feel free to merge what you want when you want.