-
Notifications
You must be signed in to change notification settings - Fork 332
Fix #209: use a proxy to access community tickets data. #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I had to use |
|
Review by @retronym , @huitseeker |
|
LGTM. Perhaps you could add a comment by the url to mention how/where the proxy is currently configured. |
I sure can, but it's a bit redundant: it's on scala-lang.org:~/local/cgi-bin, just like the rest of the Website files. Nothing special about this location compare to all the other locations. |
|
Okay, that PR comment is enough for me. |
Fix #209: use a proxy to access community tickets data.
|
@sjrd one question – who has access to ~/local/cgi-bin? I.e., which machine is it on, and who has credentials? As far as I know, just you and Chris have access. Is there some (private) place that we can document this? |
|
Ping is your friend: Access is given by Fabien through ssh keys. He would know who else has access; I have no idea. |
|
Right. I was more asking for the name of the machine at EPFL. But fine, I'll ask Fabien... Thanks... |
It's in the ping output: |
|
Yes. I could see that. I didn't ask for help reading. |
|
On second thought – I side now with Jason's original sentiment. No one other than @sjrd has access to a number of features of the website, and, correspondingly, access to how it's all configured. So lots of stuff, community tickets, hall of fame, twitter feed... Much of this is either broken or could be greatly improved but no one can really touch it. For example, I'd have liked to have fixed how tweets are displayed on the front page now for more than a year. Is there some way we can take some of this stuff out from cgi-bin, factor out the sensitive info, but put it somewhere where more than just one or two people have access to it? |
|
@sjrd Are you sure your shell script is not vulnerable to code injection ? |
|
@heathermiller Your ssh key is already on the server, you can access it... |
|
Thanks @fsalvi for the input (I actually couldn't seem to ssh into lampsrv1, I'll email you about that in private). I'll clarify and re-ask my question. There are a number of php scripts (etc) responsible for stuff like the twitter feed, etc, on lampsrv1. I am asking if it's possible to put those in a repository somewhere (with sensitive bits of information factored out of them) so that more than just one or two people can fix/improve them. I'm asking this without actually having been able to look at the scripts. So, @sjrd, you'd be able to comment on whether or not this reasonable to do. |
|
By "repository" I mean likely a public or private github repository. And perhaps the scripts still remaining in cgi-bin can pull from the repo when they run. |
As an alternative to #239