Fix documentation generation from tasty with sourcepath #24569
Closed
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bracevac
changed the title
bracevac
force-pushed
the
ob-fix-24434
branch
2 times, most recently
from
b57b358 to
77f0489
Compare
Member
We don't run cc when we compile |
bracevac
force-pushed
the
ob-fix-24434
branch
from
77f0489 to
8c14f5a
Compare
hamzaremmal
reviewed
Nov 28, 2025
|
|
||
| /** Is captureChecking enabled for any of the currently compiled compilation units? */ | ||
| /** Is captureChecking enabled for any of the currently compiled compilation units? | ||
| * Disabled when compiling from tasty since capture checking was already performed. |
Member
There was a problem hiding this comment.
There are some non-standard ways of stopping the compiler after emitting TASTy and before performing capture checking. This is then factually false.
Contributor
Author
|
It's something else that causes the issue. |
Filter out -sourcepath from doc scalacOptions as it causes conflicts with symbols loaded from tasty during documentation generation.
bracevac
force-pushed
the
ob-fix-24434
branch
from
8c14f5a to
28389d2
Compare
Contributor
Author
|
Hamza beat me to it |
hamzaremmal
added a commit
that referenced
this pull request
Nov 28, 2025
Based on @bracevac remarks here #24434 (comment) We do not need to add `-sourcepath` when generating the scaladoc since compiling with `-from-tasty` (what scaladoc does) will put the TASTy in the classpath. This means that the compiler will be happy and will find the symbols. Closes #24434 Supersedes #24569, #24510. Thanks Oliver for taking the time to analyze the issue in depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out -sourcepath from doc scalacOptions as it causes conflicts
with symbols loaded from tasty during documentation generation.
Fixes #24434