Move pylsl into the monorepo as a component - #11
Merged
neuromechanist merged 2 commits intoJul 19, 2026
Conversation
Vendored at bindings/pylsl/ from neuromechanist/pylsl branch feature/secure-lsl-support, based on upstream c90f623. Licensing follows the component policy: the upstream MIT license (Copyright (c) 2012-2018 Christian A. Kothe) is preserved unmodified in the component directory, and the security integration added here is contributed under that same MIT license. The integration is ctypes interface declarations plus StreamInfo.security_enabled() and security_fingerprint(), calling the public liblsl C API with no cryptographic implementation, so the proprietary terms do not apply. - COMPONENT.md records upstream provenance, base commit, and the graceful-degradation behavior on a stock liblsl - THIRD-PARTY-NOTICES.md gains the pylsl entry - docs/integration/pylsl.md added and wired into the nav; every symbol it references was checked against the vendored source - Dropped the vendored .github workflows so upstream CI does not fire in this repository Closes #8
6 tasks
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
First of the three component moves (#8 pylsl, #9 LabRecorder, #10 SigVisualizer). Depends on #7, now merged, which established the component licensing policy.
What moved
neuromechanist/pylslbranchfeature/secure-lsl-support(based on upstreamc90f623) is vendored atbindings/pylsl/.Licensing
Per the COMPONENT LICENSING POLICY added in #7, this component retains its upstream MIT license (Copyright (c) 2012-2018 Christian A. Kothe), preserved unmodified at
bindings/pylsl/LICENSE, and the security integration added here is contributed under that same MIT license.That is accurate rather than generous: the integration is 170 lines of
ctypesinterface declarations plusStreamInfo.security_enabled()andsecurity_fingerprint(), which call the public liblsl C API. It contains no cryptographic implementation, so there is nothing in it requiring the proprietary grant. The proprietary terms continue to cover the security implementation inliblsl/and the integrated work.Also in this PR
bindings/pylsl/COMPONENT.mdrecording upstream URL, base commit, and the graceful-degradation contractTHIRD-PARTY-NOTICES.mdentry with the verbatim MIT textdocs/integration/pylsl.md, wired into the mkdocs nav.github/so upstream CI workflows do not fire in this repositoryNote on the docs
My first draft of the docs page used
library_version()to report security status and accessedsecurity_enabled/security_fingerprintas properties. Both were wrong:library_version()returns an integer, and those two are methods. The page now usesis_secure_build(),base_version(),security_version(),full_version(), andcheck_security(), and every symbol referenced in the page was verified to exist in the vendored source before commit.Behavior against stock liblsl
Security symbols resolve inside
try/except AttributeErrorwith_security_api_availableflags, so the binding imports and behaves exactly as upstream when linked against a stockliblsl. This is what lets the same application code run against both libraries.