Merged
Conversation
Closed
BorisMuzellec
requested review from
arthurPignetOwkin and
maikia
as code owners
Contributor
|
Re: 106 -- it may or may not, I can check later today. |
Contributor
|
On my end this appears to fix the MAP convergence issue 👍
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
#106
What does your PR implement? Be specific.
This PR corrects and improves
fit_alpha_mle. As pointed out by @mikelove, there were some inconsistencies between thealphaandlog(alpha)parameterizations in the optimization routine.fit_alpha_mlewas also refactored to avoid unnecessarilly recomputinglog(alpha)andlog(alpha_hat), or computingWwhencr_reg=False.