fix: use fast-array-utils’ threadsafe njit#4015
Merged
flying-sheep merged 5 commits intomainfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
==========================================
- Coverage 78.33% 77.84% -0.50%
==========================================
Files 117 117
Lines 12769 12740 -29
==========================================
- Hits 10003 9917 -86
- Misses 2766 2823 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilan-gold
requested changes
Mar 27, 2026
ilan-gold
approved these changes
Mar 27, 2026
Contributor
ilan-gold
left a comment
There was a problem hiding this comment.
I added the benchmark label. As long as nothing regresses horribly, I think we're good
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/2ddfcc74ecc3d47124ca25848d8ea9f97ddd7f83..f07b885f9bda5480567971ec71e97831e191bf50 More details: https://github.com/scverse/scanpy/pull/4015/checks?check_run_id=69314496996 |
flying-sheep
added a commit
that referenced
this pull request
Mar 31, 2026
flying-sheep
added a commit
that referenced
this pull request
Mar 31, 2026
Marius1311
pushed a commit
to Marius1311/scanpy
that referenced
this pull request
Mar 31, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ilan-gold ported scanpy’s njit wrapper to fast-array-utils where I finally fixed it so it works as intended