Skip to content

fix: use fast-array-utils’ threadsafe njit#4015

Merged
flying-sheep merged 5 commits intomainfrom
pa/fix-njit
Mar 31, 2026
Merged

fix: use fast-array-utils’ threadsafe njit#4015
flying-sheep merged 5 commits intomainfrom
pa/fix-njit

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

  • Closes #
  • Tests included or not required because:

@ilan-gold ported scanpy’s njit wrapper to fast-array-utils where I finally fixed it so it works as intended

@flying-sheep flying-sheep added this to the 1.12.1 milestone Mar 27, 2026
@flying-sheep flying-sheep requested a review from ilan-gold March 27, 2026 16:35
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.84%. Comparing base (fe558a9) to head (08816f1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
- Coverage   78.33%   77.84%   -0.50%     
==========================================
  Files         117      117              
  Lines       12769    12740      -29     
==========================================
- Hits        10003     9917      -86     
- Misses       2766     2823      +57     
Flag Coverage Δ
hatch-test.low-vers 77.79% <100.00%> (+0.08%) ⬆️
hatch-test.pre 20.55% <100.00%> (-48.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/_compat.py 83.67% <100.00%> (+12.74%) ⬆️
...c/scanpy/experimental/pp/_highly_variable_genes.py 94.23% <100.00%> (+0.05%) ⬆️
src/scanpy/metrics/_gearys_c.py 100.00% <100.00%> (ø)
src/scanpy/metrics/_morans_i.py 100.00% <100.00%> (ø)
src/scanpy/preprocessing/_normalization.py 94.66% <100.00%> (+0.07%) ⬆️
src/scanpy/preprocessing/_qc.py 94.48% <100.00%> (-1.36%) ⬇️
src/scanpy/preprocessing/_scale.py 89.58% <100.00%> (+0.10%) ⬆️
src/scanpy/preprocessing/_simple.py 90.99% <100.00%> (+0.02%) ⬆️
src/scanpy/tools/_rank_genes_groups.py 92.83% <100.00%> (+0.02%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks we still got an old (broken) import in there judging by the tests!

Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the benchmark label. As long as nothing regresses horribly, I think we're good

@scverse-benchmark
Copy link
Copy Markdown

scverse-benchmark bot commented Mar 27, 2026

Benchmark changes

Change Before [2ddfcc7] After [f07b885] Ratio Benchmark (Parameter)
- 482±40μs 388±2μs 0.81 preprocessing_counts.FastSuite.time_log1p('pbmc68k_reduced', 'counts-off-axis')

Comparison: https://github.com/scverse/scanpy/compare/2ddfcc74ecc3d47124ca25848d8ea9f97ddd7f83..f07b885f9bda5480567971ec71e97831e191bf50
Last changed: Tue, 31 Mar 2026 08:57:44 +0000

More details: https://github.com/scverse/scanpy/pull/4015/checks?check_run_id=69314496996

@flying-sheep flying-sheep merged commit 1fbe008 into main Mar 31, 2026
5 of 6 checks passed
@flying-sheep flying-sheep deleted the pa/fix-njit branch March 31, 2026 08:46
@scverse scverse deleted a comment from lumberbot-app bot Mar 31, 2026
flying-sheep added a commit that referenced this pull request Mar 31, 2026
Marius1311 pushed a commit to Marius1311/scanpy that referenced this pull request Mar 31, 2026
@flying-sheep flying-sheep self-assigned this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants