Skip to content

Backport PR #4178 on branch 1.12.x (fix: masked cells were accidentally added to group 0 + mask ignored in aggregate computations in get.aggregate)#4181

Merged
ilan-gold merged 1 commit into
scverse:1.12.xfrom
meeseeksmachine:auto-backport-of-pr-4178-on-1.12.x
Jun 25, 2026
Merged

Conversation

@meeseeksmachine

Copy link
Copy Markdown
Contributor

Backport PR #4178: fix: masked cells were accidentally added to group 0 + mask ignored in aggregate computations in get.aggregate

…o group 0 + mask ignored in aggregate computations in `get.aggregate`
@lumberbot-app lumberbot-app Bot added this to the 1.12.2 milestone Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.60%. Comparing base (82b91c5) to head (fc6b350).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           1.12.x    #4181      +/-   ##
==========================================
+ Coverage   78.58%   78.60%   +0.01%     
==========================================
  Files         121      121              
  Lines       12685    12688       +3     
==========================================
+ Hits         9969     9973       +4     
+ Misses       2716     2715       -1     
Flag Coverage Δ
hatch-test.low-vers 77.66% <94.73%> (+0.03%) ⬆️
hatch-test.pre 78.49% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/get/_aggregated.py 93.41% <100.00%> (+0.46%) ⬆️

@ilan-gold
ilan-gold merged commit 362d71d into scverse:1.12.x Jun 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants