Infrastructure cleanup#400
Open
Darlokt wants to merge 4 commits into
Open
Conversation
This commit cleans up the infrastructure and project configuration by removing unused files and updating the remaining ones. Changes: - Deleted `.bumpversion.cfg` as it is not used in the project. - Deleted `.mypy.ini` and integrated it into `pyproject.toml` under the `tool.mypy` section. - Bumped the python version to 3.11 in the mypy configuration to reflect the minimum supported version. - Updated `.pre-commit-config.yaml` to remove unused hooks and dependencies. - Removed the `mirrors-prettier` hook as it is conflicting with `ruff` and `.editorconfig` settings. - Removed the `check-ast`, `end-of-file-fixer`, `mixed-line-ending` and `trailing-whitespace` hooks as they are redundant with `ruff`. - Cleaned up the `pyproject.toml` and updated tool configs - Split the `tool.ruff` configuration into multiple sections to improve readability and maintainability. - Updated the `ruff` to reflect the `.editorconfig` settings (indentation, line endings, etc.) - Set the `ruff` minimum python version to 3.11 to reflect the minimum supported version. - Converted optional dependencies into dependency groups in line with PEP 735, to improve the organization and clarity of the dependencies. - Removed `pre` dependency group as it is not different to the main dependencies and only used for `.readthedocs.yaml`. - Removed `bump2version` from the `dev` dependency group as it is not used in the project and abandoned. - Updated `.readthedocs.yaml` - Removed the `pre` dependency group from the installation command as it is not different to the main dependencies and only used for `.readthedocs.yaml`. - Updated resolver to use `uv` instead of `pip` to install dependencies, as it is faster and works with dependency groups.
This commit adds the "docstring-convention" rule to the ruff configuration in pyproject.toml. It enforces the use of a consistent numpydoc style for docstrings across the codebase, in line with the project's documentation standards.
This commit updates the test CI job to use dependency groups defined in the pyproject.toml file and bumps action versions. Changes: - Updated the test CI job to use dependency groups defined in pyproject.toml. - Replace manual pip cache with the built-in caching mechanism of the setup-python action. - Bumped action versions to the latest available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 63.38% 63.38%
=======================================
Files 26 26
Lines 3217 3217
=======================================
Hits 2039 2039
Misses 1178 1178 🚀 New features to boost your workflow:
|
Author
|
Fixed CI workflow. Updated it to work with dependency groups and replaced manual caching with |
Member
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hej evreyone,
I have a project depending on this project and saw there is some cleanup potential in preparation for some bigger refactors/cleanups.
This is a patch series cleaning up the projects infrastructure. Removing/consolidates unnecessary/no longer used files/configs and updating tool configs etc. in preparation for a general cleanup/restructure.
Changes:
.bumpversion.cfgas it is not used in the project..mypy.iniand integrated it intopyproject.tomlunder thetool.mypysection..pre-commit-config.yamlto remove unused hooks and dependencies.mirrors-prettierhook as it is conflicting withruffand.editorconfigsettings.check-ast,end-of-file-fixer,mixed-line-endingandtrailing-whitespacehooks as they are redundant withruff.ruffpyproject.tomland updated tool configstool.ruffconfiguration into multiple sections to improve readability and maintainability.ruffto reflect the.editorconfigsettings (indentation, line endings, etc.)ruffminimum python version to 3.11 to reflect the minimum supported version.rufflinting config in line with project standards.predependency group as it is not different to the main dependencies and only used for.readthedocs.yaml.bump2versionfrom thedevdependency group as it is not used in the project and abandoned..readthedocs.yamlpredependency group from the installation command as it is not different to the main dependencies and only used for.readthedocs.yaml.uvinstead ofpipto install dependencies, as it is faster and works with the implemented dependency groups.