Improved error message for incorrect gene_symbols columns#658
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 77.07% 77.49% +0.41%
==========================================
Files 11 11
Lines 3280 3572 +292
Branches 774 838 +64
==========================================
+ Hits 2528 2768 +240
- Misses 454 481 +27
- Partials 298 323 +25
🚀 New features to boost your workflow:
|
Member
|
Hey @SAY-5, thank you for your contribution. |
gene_symbols columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #618.
_validate_col_for_column_tableswallowed theKeyErrorfrom_resolve_gene_symbolson the auto-detect branch, so a wronggene_symbols=column name surfaced as the generic "Unable to locate color key" message. Now the lookup column is validated against every annotating table'svarcolumns before the per-table loop, so a typo raises immediately with the available column names.Added a regression test on the auto-detect path (without
table_name=).