Parameter palette can now be used without specifying groups#659
Merged
timtreis merged 1 commit intoMay 12, 2026
Merged
Conversation
Closes scverse#605. Signed-off-by: SAY-5 <say.apm35@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
- Coverage 77.50% 77.48% -0.02%
==========================================
Files 11 11
Lines 3569 3567 -2
Branches 837 836 -1
==========================================
- Hits 2766 2764 -2
+ Misses 481 480 -1
- Partials 322 323 +1
🚀 New features to boost your workflow:
|
palette can now be used without specifying groups
Member
|
Hey @SAY-5, thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #605.
_validate_render_paramsraisedValueError: When specifying 'palette', 'groups' must also be specifiedwheneverpalette=listwas supplied withoutgroups=. The dict path has no such restriction, so a list of three colors against three categories forced users to redundantly re-list every category just to satisfy validation.Dropped the
groups is Nonerequirement; the existing length check at_get_colors_for_categorical_obsalready raises if the list does not match the category count, and the natural-order mapping there now applies. Regression test intest_render_shapes.pyasserts the legend matches the underlying categories.