Raise clear error for all-empty shapes#674
Merged
Merged
Conversation
Previously `render_shapes(...).show()` crashed with a bare upstream
`AssertionError("Cannot compute extent of an empty collection of
geometries.")` when every geometry in a shape element was empty. Detect
this up front before calling `get_extent` and raise a `ValueError`
naming the element(s) and coordinate system instead.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 11 11
Lines 3612 3630 +18
Branches 850 858 +8
=======================================
+ Hits 2804 2818 +14
- Misses 485 486 +1
- Partials 323 326 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_extentinPlotAccessor.show.AssertionError("Cannot compute extent of an empty collection of geometries.")with aValueErrorthat names the offending element(s) and coordinate system.Closes #629.