Raise clear error for 3D (z-stack) images and labels#675
Merged
Conversation
3D z-stack inputs to render_images / render_labels previously crashed
deep in matplotlib ("Invalid shape") or numpy (concatenation error)
with no mention of the unsupported dimensionality. Add an early guard
on _render_images and _render_labels that raises a ValueError naming
the element, z-size, and a concrete .isel(z=0) workaround. Handles
both DataArray and multiscale DataTree inputs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
+ Coverage 77.66% 77.72% +0.06%
==========================================
Files 11 11
Lines 3626 3637 +11
Branches 856 858 +2
==========================================
+ Hits 2816 2827 +11
Misses 485 485
Partials 325 325
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_images/render_labelspreviously crashed deep in matplotlib (Invalid shape) or numpy (concatenation error) with no mention of the unsupported dimensionality._render_imagesand_render_labelsthat raises a clearValueErrornaming the element, z-size, and a concrete.isel(z=0)workaround.DataArrayand multiscaleDataTreeinputs via a small_get_top_data_arrayhelper.3D rendering remains unsupported (see #386)