Skip to content

Reduce warnings#1113

Merged
LucaMarconato merged 13 commits intomainfrom
less-warnings
May 5, 2026
Merged

Reduce warnings#1113
LucaMarconato merged 13 commits intomainfrom
less-warnings

Conversation

@LucaMarconato
Copy link
Copy Markdown
Member

Reduce warnings, in particular:

  • Use zip(strict=True) when converting tuple chunks to dict in RasterSchema
  • Copy AnnData views before modifying .uns in TableModel.parse
  • Use explicit string obs index in AnnData construction to avoid implicit index warnings
  • Add .copy() after compute()/slice to avoid pandas SettingWithCopyWarning (CoW)
  • Remove unused docs/_templates autosummary files
  • Update tutorials submodule
  • Fix pandas CoW issues

LucaMarconato and others added 5 commits May 5, 2026 13:59
- Use zip(strict=True) when converting tuple chunks to dict in RasterSchema
- Copy AnnData views before modifying .uns in TableModel.parse
- Use explicit string obs index in AnnData construction to avoid implicit index warnings
- Add .copy() after compute()/slice to avoid pandas SettingWithCopyWarning (CoW)
- Remove unused docs/_templates autosummary files
- Update tutorials submodule

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (8d7f72f) to head (7df090f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   91.93%   91.87%   -0.07%     
==========================================
  Files          51       51              
  Lines        7772     7775       +3     
==========================================
- Hits         7145     7143       -2     
- Misses        627      632       +5     
Files with missing lines Coverage Δ
src/spatialdata/datasets.py 100.00% <100.00%> (ø)
src/spatialdata/models/models.py 87.78% <100.00%> (-0.89%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LucaMarconato and others added 6 commits May 5, 2026 14:55
…ss INFO noise

Build the dataframe with only the coordinate columns actually needed for
each branch: source columns (A/B/C) when a coordinates mapping is provided,
target columns (x/y/z) otherwise. This prevents the rename-drop and
z-ignored-in-2D INFO messages (240 occurrences) from firing during tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…o suppress WARNING noise

The target column was a plain str Series; PointsModel.parse() converted it
to an unknown-categories dask Categorical, triggering a performance warning
on every parametrized invocation. Using pd.Categorical with known categories
up-front avoids the conversion path entirely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…format tests

Use `re.match`-compatible pattern (anchored at start) and add
`@pytest.mark.filterwarnings` to standalone parametrized tests outside
`TestReadWrite` that intentionally exercise the V01 container format.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ilterwarnings

Replace verbose autouse fixtures (catch_warnings + isinstance check) with a
single @pytest.mark.filterwarnings decorator on each class/function. The
isinstance guard was unnecessary because V02 tests never emit the warning,
so the filter is a harmless no-op for them. Also removes now-unused
`import warnings` from test_format.py and test_readwrite.py, and
CurrentSpatialDataContainerFormat from test_attrs_io.py.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@LucaMarconato
Copy link
Copy Markdown
Member Author

Recap:

  • Reduced the number of warnings in general
  • Approximately halved the numbers of warnings emitted (and not caught) during tests. ~100 left
  • Greatly reduced the number of logs (INFO, WARNING), during tests.

@LucaMarconato LucaMarconato merged commit d0582ec into main May 5, 2026
12 checks passed
@LucaMarconato LucaMarconato deleted the less-warnings branch May 5, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant