Tranformation copy#283
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 89.90% 89.90%
=======================================
Files 36 36
Lines 4408 4410 +2
=======================================
+ Hits 3963 3965 +2
Misses 445 445
|
Member
|
Perfect thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is the case that a user creates a transformation dictionary which is used while parsing multiple data sources into spatialdata elements. When on top of that setting an additional transformation later for one specific element, all the other elements have the transformation set as well. As suggested by @LucaMarconato, this PR fixes this issue by creating a dictionary copy in the parse function if
transformationsis notNone. Also, a test has been added.