Skip to content

specify n_channels#307

Merged
kevinyamauchi merged 4 commits into
scverse:mainfrom
melonora:3d_blobs
Jun 24, 2023
Merged

specify n_channels#307
kevinyamauchi merged 4 commits into
scverse:mainfrom
melonora:3d_blobs

Conversation

@melonora

Copy link
Copy Markdown
Collaborator

This is for writing tests in napari-spatialdata where for RGB it is required to specify the number of channels.

@codecov

codecov Bot commented Jun 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #307 (902f7d9) into main (b2c43b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          36       36           
  Lines        4623     4624    +1     
=======================================
+ Hits         4195     4196    +1     
  Misses        428      428           
Impacted Files Coverage Δ
src/spatialdata/datasets.py 100.00% <100.00%> (ø)

@melonora

Copy link
Copy Markdown
Collaborator Author

@LucaMarconato @kevinyamauchi Could one of you review this please and then release? The test for RGB in napari-spatialdata depends on it.

@kevinyamauchi kevinyamauchi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@giovp , can you please take a look? I don't understand the notebook submodule diff. Why is that showing up here? Is it just saying that the notebooks repo was updated separately and those changes will be committed here now?

@giovp

giovp commented Jun 23, 2023

Copy link
Copy Markdown
Member

should be good but to be extra sure @melonora could you fetch and pull from the submodule and push again with the latest version? then you shouldn't have those diffs. I think we need to add that folder to gitignore to prevent this.

@kevinyamauchi

Copy link
Copy Markdown
Collaborator

Thanks for the update, @melonora ! The diff now looks good. I will merge now.

@kevinyamauchi kevinyamauchi merged commit fa096da into scverse:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants