specify n_channels#307
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 36 36
Lines 4623 4624 +1
=======================================
+ Hits 4195 4196 +1
Misses 428 428
|
|
@LucaMarconato @kevinyamauchi Could one of you review this please and then release? The test for RGB in napari-spatialdata depends on it. |
kevinyamauchi
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@giovp , can you please take a look? I don't understand the notebook submodule diff. Why is that showing up here? Is it just saying that the notebooks repo was updated separately and those changes will be committed here now?
|
should be good but to be extra sure @melonora could you fetch and pull from the submodule and push again with the latest version? then you shouldn't have those diffs. I think we need to add that folder to gitignore to prevent this. |
|
Thanks for the update, @melonora ! The diff now looks good. I will merge now. |
This is for writing tests in napari-spatialdata where for RGB it is required to specify the number of channels.