Skip to content

Asn1 oer uper contrib - #5050

Draft
polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:asn1-oer-uper-contrib
Draft

Asn1 oer uper contrib#5050
polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:asn1-oer-uper-contrib

Conversation

@polybassa

Copy link
Copy Markdown
Contributor

No description provided.

Nils Weiss added 2 commits August 7, 2026 18:31
Move OER/UPER codec implementations to scapy.contrib and wire
asn1fields for OER/PER using the pluggable tagging/kwargs hooks.

AI-Assisted: yes (Cursor)
AI-Assisted: yes (Cursor)
@polybassa
polybassa force-pushed the asn1-oer-uper-contrib branch from e7bc1d3 to 4cdc2de Compare August 7, 2026 18:45
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.31439% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.74%. Comparing base (d8f7b27) to head (d0a7770).

Files with missing lines Patch % Lines
scapy/contrib/uper.py 89.92% 105 Missing ⚠️
scapy/contrib/oer.py 86.96% 67 Missing ⚠️
scapy/asn1fields.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5050      +/-   ##
==========================================
+ Coverage   80.48%   80.74%   +0.26%     
==========================================
  Files         390      392       +2     
  Lines       96810    98412    +1602     
==========================================
+ Hits        77917    79463    +1546     
- Misses      18893    18949      +56     
Files with missing lines Coverage Δ
scapy/asn1/asn1.py 87.13% <100.00%> (+0.28%) ⬆️
scapy/asn1/ber.py 96.71% <100.00%> (+0.53%) ⬆️
scapy/asn1fields.py 95.22% <98.27%> (+7.34%) ⬆️
scapy/contrib/oer.py 86.96% <86.96%> (ø)
scapy/contrib/uper.py 89.92% <89.92%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Nils Weiss added 4 commits August 8, 2026 07:11
AI-Assisted: yes (Cursor)
AI-Assisted: yes (Cursor)
AI-Assisted: yes (Cursor)
AI-Assisted: yes (Cursor)
Comment thread scapy/asn1/ber.py
codec = ASN1_Codecs.BER
tag = ASN1_Class_UNIVERSAL.ANY
skip_tagging = False
tagging_enc = staticmethod(BER_tagging_enc)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we removed those in the previous PR and moved them to 'self.codec'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants