This repository was archived by the owner on Feb 16, 2023. It is now read-only.
Closed
Conversation
Merged
Member
SimonBarendse
left a comment
SimonBarendse
left a comment
There was a problem hiding this comment.
The path is really nice feedback to have when a secret cannot be found, so that you can better determine where the problem is.
I think this is valuable for a lot more usecases, for example:
secrethub inject- (multiple)
secrethub reads, e.g. in a script:./my-script.sh - (multiple ) reads by the Terraform provider
Therefore, shall we add this in secrethub-go instead, so that every secret not found error includes the path in the error message?
Member
Author
Good point! I will implement it in the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.