[pull] master from apache:master - #653
Merged
Merged
Conversation
* Update IO support matrix after Beam 2.76.0 release * Fix CHANGES.md wrong version * Fix Yamldoc empty for certain transforms due to expansion service is not present * Remove item that not affect any release
The global filter turns off MS_EXPOSE_REP for every module. That hides 34 findings today, and hides any new one automatically. Remove that line and mark the existing sites one by one with @SuppressFBWarnings, each carrying the reason it is exempt. Nothing changes at runtime. What changes is that the next accessor someone writes that returns a mutable static will fail spotbugsMain instead of passing quietly. The three Guava sites cannot be configured away. SpotBugs checks its list of known immutable types by fully qualified name, so it does not recognise Guava relocated into org.apache.beam.vendor.guava, and the fallback scan finds setter-named methods on ImmutableCollection. See spotbugs/spotbugs#1601. Addresses #35312.
* valuekind coder * spotless
* spec-aware * fix(iceberg): drop the Logger orphaned by the fallback-warning removal ErrorProne -Werror fails compileJava on the unused field, and the test javadoc linked the deleted method. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Ahmed Abualsaud <ahmedabualsaud@MacBook-Pro-2.local> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* AddFiles: tighten file schemas with footer null counts, folded per declared schema Parquet writers commonly declare every column optional whatever the data holds. Taken at face value, a file with no nulls in a column the table has as required would ask the pre-pass to relax that column for no reason. Tightening uses the footer's null counts to drop such requests. The evidence travels beside the schema, not inside it. ReadFooterSchema emits (canonical declared-schema JSON, proven-null-free paths) and CollectDistinctSchemas folds the paths per distinct schema by intersection: a column stays proven only when every file proved it, equivalently a relaxation is requested when any file needs it. The commit side will rebuild the group's most conservative member with FileSchemas.markRequired before classifying, which produces the same table schema as tightening each file individually would. union adds new columns as optional whatever the file declares. Tightening only affects columns the table already has as required: the union adds new columns as optional whatever the file declares. * comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )