Merged
Conversation
secup
added a commit
that referenced
this pull request
May 3, 2026
Tonight's autonomous code-quality pass on the new TNC + HARQ work, informed by Codex review (full notes /tmp/codex_quality_findings.md, 22 ranked findings). Tackled the safe ones with high impact: Safety / correctness (#3, #7-#8, #14): - ultra_tnc: skip config loading on --help / --list-audio-devices so a malformed config doesn't break operator recovery - tnc_session: cmdStats() now null-guards cmd_emit_, matching the rest of the emit path (was the one place that could throw std::bad_function_call on a null callback) - tnc_bridge: postPTT() callbacks no longer fire under ptt_mutex_. Computes the PTT transition under the lock, releases, then invokes sink + hardware callback. Closes a deadlock window when a slow hardware-PTT serial write blocks under the mutex. - (#7 PTT setLine() return-check deferred — needs decision on whether to fail-startup or fall-back-to-VOX. Punted to follow-up.) Tests (#12, #19-#20): - 1 new test_tnc_session: corrupt-deflate RX silently dropped (regression guard for the marker-strip path) - 6 new test_soft_combine cases: * setEnabled(false) clears retained entries * Zero sender_hash is a no-op (don't pollute future sessions) * setMaxEntries(0) disables retention * Empty-LLR retain is a no-op * Saturation: pin to exact implementation cap (60.0) on both + and - sides instead of just "<= 100" Docs / comments (#18, #22): - soft_combine.hpp: comment on carrier_count_hash now matches what the hash actually contains (was claiming pilot-spacing coverage we don't actually do) - PAT_VARA_AUDIT.md: trailing-whitespace cleanup Local ctest 34/34. Test counts: SoftCombine 10→16, TNCSession 98→100, TNCBridge 17→23. Net +14 tests. Deferred (need broader judgment, not autonomous-safe): - #2 extract config helpers to testable target (refactor) - #5 explicit negative CLI flags (interface design) - #9 sink ownership lifetime race (concurrency design) - #11 BUFFER 0 immediacy vs rate-limit (protocol judgment) - #13 flushDataTxBuffer extraction for testability - #15 sendBinary error propagation (interface change) - #16 HARQ key construction extraction - #17 HARQ when CW0 fails (architectural) - #21 UltraTNCStation threading model Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: Codex (review) <noreply@openai.com>
secup
added a commit
that referenced
this pull request
May 3, 2026
- Add parsePositiveIntStrict / parseBoolStrict helpers — full string consumed, no leading sign chars, range-checked. Replaces loose std::stoi / equality-list parsing in applyConfigKey and CLI for inject_channel, ptt_serial_baud, ptt_inactive_high. "9600abc" or "-50" no longer silently parse as 9600 / 50. - If serial PTT setLine() fails on initial inactive-state set, refuse to start — running with PTT in an unknown state risks keying the radio. Mid-session callback failures are logged but non-fatal so a USB unplug doesn't crash the modem. Closes Codex review items #4 and #7. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
secup
added a commit
that referenced
this pull request
May 3, 2026
Updated QUALITY_PASS doc to reflect the final state of tonight's two-batch quality work. Eleven findings were closed in the second batch (#2, #4, #5, #7, #9, #10, #11, #13, #15, #16, #17). Combined with the first batch's ten, that's 21/22 closed. Only the UltraTNCStation threading-model rework is deferred, and Codex itself flagged that as requiring human concurrency design. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated agent task.
Task:
agents/queue/codex/002-arq-property-tests.mdBranch:
agent/20260430_153954-002-arq-property-testsBase:
mainRequired Review
agents/reports/20260430_153954-002-arq-property-tests.Agent Report
See local report directory:
agents/reports/20260430_153954-002-arq-property-tests