Skip to content

Update go-releaser heading with experimental notice - #3879

Merged
masih merged 1 commit into
mainfrom
masih/gorleaser-experimenta
Aug 7, 2026
Merged

Update go-releaser heading with experimental notice#3879
masih merged 1 commit into
mainfrom
masih/gorleaser-experimenta

Conversation

@masih

@masih masih commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

To avoid confusing validators and to test the whole process more in terms of templating, make it clear that statically linked binaries are experimental and use a H2 header.

@masih
masih requested a review from monty-sei August 7, 2026 15:12
@masih
masih enabled auto-merge August 7, 2026 15:13
@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Release note templating only; no build, binary, or runtime behavior changes.

Overview
Updates the GoReleaser release header so GitHub releases no longer open with a version-only # Sei {{ .Tag }} title.

The header now uses ## Experimental Pre-built Binaries, signaling that attached statically linked seid artifacts are experimental. Checksum instructions and the Docker image pointer are unchanged.

Reviewed by Cursor Bugbot for commit 807e96e. Bugbot is set up for automated code reviews on this repo. Configure here.

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line cosmetic change to the goreleaser release-notes header (H1 tag title → H2 "Experimental Pre-built Binaries"); the change is correct and self-consistent with name_template and mode: append. Only nits remain, plus a note that the Cursor review pass produced no output.

Findings: 0 blocking | 4 non-blocking | 1 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • The Cursor second-opinion review file (cursor-review.md) is empty — that pass produced no output, so this review reflects Claude + Codex only. Codex reported "No material findings."
  • PR description says the change is partly "to test the whole process more in terms of templating," but the diff removes the only template expression ({{ .Tag }}) from the header. Templating is still exercised via name_template, so nothing is broken — just a minor mismatch between the stated rationale and the diff.
  • No CHANGELOG entry. The closely related goreleaser release-notes change (#3857) was recorded under ## v6.6 in CHANGELOG.md; for consistency this backport-labelled PR could add a line under ## Unreleased### Improvements. Skip if release-notes cosmetics are intentionally excluded from the changelog.
  • 1 suggestion(s)/nit(s) flagged inline on specific lines.

Comment thread .goreleaser.yaml
name_template: '{{ .Tag }}'
header: |
# Sei {{ .Tag }}
## Experimental Pre-built Binaries

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The stated goal is to "avoid confusing validators," but the heading now asserts "Experimental" without saying what that implies. Consider one qualifying sentence so a validator reading the release page knows what to do with it — e.g. "These statically-linked binaries are experimental; for production use the Docker images below." As written, the reader learns the status but not the recommendation, and the body text underneath is unchanged from when the heading was just the tag name.

The H1 → H2 demotion itself is right: name_template: '{{ .Tag }}' already supplies the tag as the release title, so the old # Sei {{ .Tag }} duplicated it, and H2 nests correctly under the auto-generated body that mode: append appends to.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 7, 2026, 3:16 PM

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.87%. Comparing base (aaf8bdb) to head (807e96e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3879      +/-   ##
==========================================
- Coverage   61.73%   60.87%   -0.86%     
==========================================
  Files        2382     2288      -94     
  Lines      201795   191299   -10496     
==========================================
- Hits       124577   116455    -8122     
+ Misses      66130    64593    -1537     
+ Partials    11088    10251     -837     
Flag Coverage Δ
sei-db 70.41% <ø> (-0.22%) ⬇️
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
masih added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit f0ace34 Aug 7, 2026
74 of 77 checks passed
@masih
masih deleted the masih/gorleaser-experimenta branch August 7, 2026 15:58
@seidroid

seidroid Bot commented Aug 7, 2026

Copy link
Copy Markdown

Successfully created backport PR for release/v6.6:

yzang2019 added a commit that referenced this pull request Aug 7, 2026
* main:
  test(config): complete the GetConfig read-site coverage (PLT-893) (#3870)
  Remove interchain swagger API and protos (#3881)
  fix(flatkv): preserve empty misc values and reject malformed empty node imports (#3869)
  fix(evm): count post-admission apply failures in dynamic base-fee gas (CON-359) (#3871)
  scripts: load generator for arctic-1 and atlantic-2 (#3850)
  Update go-releaser heading with experimental notice (#3879)
  fix(evmrpc): stream request-body budget charging to close slowloris gap (PLT-780) (#3836)
  Remove unused interchain accounts implementation (#3875)
  test(config): extend golden value test coverage (PLT-893) (#3861)
  Update v6.6 changelog in prep to cut patch release (#3876)
  Close temporary rootmulti store in connection types setup (#3872)
  Restore LCD pagination while preserving v6.6 precompile semantics (#3867)
masih added a commit that referenced this pull request Aug 7, 2026
… notice (#3880)

Backport of #3879 to `release/v6.6`.

Co-authored-by: Masih H. Derkani <m@derkani.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants