Update go-releaser heading with experimental notice - #3879
Conversation
PR SummaryLow Risk Overview The header now uses Reviewed by Cursor Bugbot for commit 807e96e. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
One-line cosmetic change to the goreleaser release-notes header (H1 tag title → H2 "Experimental Pre-built Binaries"); the change is correct and self-consistent with name_template and mode: append. Only nits remain, plus a note that the Cursor review pass produced no output.
Findings: 0 blocking | 4 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The Cursor second-opinion review file (
cursor-review.md) is empty — that pass produced no output, so this review reflects Claude + Codex only. Codex reported "No material findings." - PR description says the change is partly "to test the whole process more in terms of templating," but the diff removes the only template expression (
{{ .Tag }}) from the header. Templating is still exercised vianame_template, so nothing is broken — just a minor mismatch between the stated rationale and the diff. - No CHANGELOG entry. The closely related goreleaser release-notes change (#3857) was recorded under
## v6.6inCHANGELOG.md; for consistency this backport-labelled PR could add a line under## Unreleased→### Improvements. Skip if release-notes cosmetics are intentionally excluded from the changelog. - 1 suggestion(s)/nit(s) flagged inline on specific lines.
| name_template: '{{ .Tag }}' | ||
| header: | | ||
| # Sei {{ .Tag }} | ||
| ## Experimental Pre-built Binaries |
There was a problem hiding this comment.
[nit] The stated goal is to "avoid confusing validators," but the heading now asserts "Experimental" without saying what that implies. Consider one qualifying sentence so a validator reading the release page knows what to do with it — e.g. "These statically-linked binaries are experimental; for production use the Docker images below." As written, the reader learns the status but not the recommendation, and the body text underneath is unchanged from when the heading was just the tag name.
The H1 → H2 demotion itself is right: name_template: '{{ .Tag }}' already supplies the tag as the release title, so the old # Sei {{ .Tag }} duplicated it, and H2 nests correctly under the auto-generated body that mode: append appends to.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3879 +/- ##
==========================================
- Coverage 61.73% 60.87% -0.86%
==========================================
Files 2382 2288 -94
Lines 201795 191299 -10496
==========================================
- Hits 124577 116455 -8122
+ Misses 66130 64593 -1537
+ Partials 11088 10251 -837
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Successfully created backport PR for |
* main: test(config): complete the GetConfig read-site coverage (PLT-893) (#3870) Remove interchain swagger API and protos (#3881) fix(flatkv): preserve empty misc values and reject malformed empty node imports (#3869) fix(evm): count post-admission apply failures in dynamic base-fee gas (CON-359) (#3871) scripts: load generator for arctic-1 and atlantic-2 (#3850) Update go-releaser heading with experimental notice (#3879) fix(evmrpc): stream request-body budget charging to close slowloris gap (PLT-780) (#3836) Remove unused interchain accounts implementation (#3875) test(config): extend golden value test coverage (PLT-893) (#3861) Update v6.6 changelog in prep to cut patch release (#3876) Close temporary rootmulti store in connection types setup (#3872) Restore LCD pagination while preserving v6.6 precompile semantics (#3867)
To avoid confusing validators and to test the whole process more in terms of templating, make it clear that statically linked binaries are experimental and use a H2 header.