Skip to content

Remove interchain swagger API and protos - #3881

Merged
masih merged 1 commit into
mainfrom
masih/relax-ibc-relay-tests
Aug 7, 2026
Merged

Remove interchain swagger API and protos#3881
masih merged 1 commit into
mainfrom
masih/relax-ibc-relay-tests

Conversation

@masih

@masih masih commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Now that interchain accounts is deleted, remove the proto and swagger APIs. This breaking change in proto + APIs is expected since in and out bound IBC is disabled.

Now that interchain accounts is deleted, remove the proto and swagger
APIs. This breaking change in proto + APIs is expected since in and out
bound IBC is disabled.
@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Breaking change to public gRPC/REST and proto contracts; low runtime risk on-chain if ICA is already gone, but integrators and codegen that still reference ICA paths will break.

Overview
Follow-up cleanup after interchain accounts (ICA) was removed from the chain: this PR deletes the remaining ICA protobuf definitions under sei-ibc-go/proto/ibc/applications/interchain_accounts/ (controller, host, shared account/genesis/metadata/packet types and gRPC query services) and strips matching OpenAPI surface from docs/swagger-ui/swagger.yml (e.g. host Params query path and related schema types).

This is an intentional breaking API/proto change aligned with disabled inbound/outbound IBC ICA behavior—clients must not rely on these REST or proto endpoints anymore.

Reviewed by Cursor Bugbot for commit 062f942. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 7, 2026, 6:06 PM

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, complete removal of the ICS-27 interchain accounts protos and swagger entries — no dangling references, no orphaned generated code, and the buf breaking rules in use (WIRE/WIRE_JSON) permit the deletion. Two non-blocking follow-ups: the served swagger bundle (docs/swagger/statik.go) wasn't regenerated, and sei-ibc-go/README.md still lists ICS 27.

Findings: 0 blocking | 5 non-blocking | 1 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • sei-ibc-go/README.md:54 still lists "2.2 [ICS 27 Interchain Accounts]" in its module index. Now that the protos are gone alongside the already-deleted module, that entry is stale and worth dropping in this PR.
  • Heads-up on tooling, not this PR's fault: scripts/update-swagger-ui-statik.sh uses sed -i '', which is BSD/macOS-only and fails on GNU sed (Linux). Anyone regenerating the statik bundle on Linux will need sed -i without the empty-argument form.
  • The Cursor second-opinion pass produced no output (cursor-review.md is empty). Codex reported no material findings. This review is therefore effectively a single-reviewer pass plus my own verification.
  • Verified for the record, so it doesn't get re-flagged: repo-wide grep on the merged tree finds no remaining interchain_accounts references outside the README, no orphaned *.pb.go, and no proto still importing the deleted files — so buf build won't break on missing imports. Root buf.yaml scopes sei-ibc-go/proto under breaking: use: [WIRE, WIRE_JSON], which permits deletions (the *_NO_DELETE rules are in the FILE/PACKAGE categories), and proto-registry.yml only pushes proto/** while sei-ibc-go/proto has no module name — so no published buf module is affected.
  • 1 suggestion(s)/nit(s) flagged inline on specific lines.

type: boolean
tags:
- Query
/ibc/apps/interchain_accounts/host/v1/params:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] Editing this file alone doesn't change what a node actually serves. docs/swagger/statik.go is the statik-embedded copy of docs/swagger-ui/ (I confirmed the bundle contains a swagger.yml entry), and it's what app/app.go:2772 RegisterSwaggerAPI mounts at /swagger/ via fs.NewWithNamespace("swagger"). Since statik.go is unchanged in this PR, the running node's swagger UI will still advertise /ibc/apps/interchain_accounts/host/v1/params for an endpoint that no longer exists.

Re-running scripts/update-swagger-ui-statik.sh to regenerate docs/swagger/statik.go would make the change reach the served docs. Non-blocking — docs-only, no runtime or consensus impact — and note the embedded copy may already have been drifting from this file before this PR, in which case this is pre-existing rather than newly introduced. Either way, the removal doesn't propagate without the regen.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (0278f2c) to head (062f942).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3881      +/-   ##
==========================================
- Coverage   61.61%   60.75%   -0.87%     
==========================================
  Files        2348     2254      -94     
  Lines      200842   190346   -10496     
==========================================
- Hits       123751   115646    -8105     
+ Misses      66033    64479    -1554     
+ Partials    11058    10221     -837     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 94 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
masih added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit c464ac9 Aug 7, 2026
74 of 75 checks passed
@masih
masih deleted the masih/relax-ibc-relay-tests branch August 7, 2026 18:50
yzang2019 added a commit that referenced this pull request Aug 7, 2026
* main:
  test(config): complete the GetConfig read-site coverage (PLT-893) (#3870)
  Remove interchain swagger API and protos (#3881)
  fix(flatkv): preserve empty misc values and reject malformed empty node imports (#3869)
  fix(evm): count post-admission apply failures in dynamic base-fee gas (CON-359) (#3871)
  scripts: load generator for arctic-1 and atlantic-2 (#3850)
  Update go-releaser heading with experimental notice (#3879)
  fix(evmrpc): stream request-body budget charging to close slowloris gap (PLT-780) (#3836)
  Remove unused interchain accounts implementation (#3875)
  test(config): extend golden value test coverage (PLT-893) (#3861)
  Update v6.6 changelog in prep to cut patch release (#3876)
  Close temporary rootmulti store in connection types setup (#3872)
  Restore LCD pagination while preserving v6.6 precompile semantics (#3867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants