Remove interchain swagger API and protos - #3881
Conversation
Now that interchain accounts is deleted, remove the proto and swagger APIs. This breaking change in proto + APIs is expected since in and out bound IBC is disabled.
PR SummaryMedium Risk Overview This is an intentional breaking API/proto change aligned with disabled inbound/outbound IBC ICA behavior—clients must not rely on these REST or proto endpoints anymore. Reviewed by Cursor Bugbot for commit 062f942. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Clean, complete removal of the ICS-27 interchain accounts protos and swagger entries — no dangling references, no orphaned generated code, and the buf breaking rules in use (WIRE/WIRE_JSON) permit the deletion. Two non-blocking follow-ups: the served swagger bundle (docs/swagger/statik.go) wasn't regenerated, and sei-ibc-go/README.md still lists ICS 27.
Findings: 0 blocking | 5 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
sei-ibc-go/README.md:54still lists "2.2 [ICS 27 Interchain Accounts]" in its module index. Now that the protos are gone alongside the already-deleted module, that entry is stale and worth dropping in this PR.- Heads-up on tooling, not this PR's fault:
scripts/update-swagger-ui-statik.shusessed -i '', which is BSD/macOS-only and fails on GNU sed (Linux). Anyone regenerating the statik bundle on Linux will needsed -iwithout the empty-argument form. - The Cursor second-opinion pass produced no output (
cursor-review.mdis empty). Codex reported no material findings. This review is therefore effectively a single-reviewer pass plus my own verification. - Verified for the record, so it doesn't get re-flagged: repo-wide grep on the merged tree finds no remaining
interchain_accountsreferences outside the README, no orphaned*.pb.go, and no proto still importing the deleted files — sobuf buildwon't break on missing imports. Rootbuf.yamlscopessei-ibc-go/protounderbreaking: use: [WIRE, WIRE_JSON], which permits deletions (the*_NO_DELETErules are in theFILE/PACKAGEcategories), andproto-registry.ymlonly pushesproto/**whilesei-ibc-go/protohas no module name — so no published buf module is affected. - 1 suggestion(s)/nit(s) flagged inline on specific lines.
| type: boolean | ||
| tags: | ||
| - Query | ||
| /ibc/apps/interchain_accounts/host/v1/params: |
There was a problem hiding this comment.
[suggestion] Editing this file alone doesn't change what a node actually serves. docs/swagger/statik.go is the statik-embedded copy of docs/swagger-ui/ (I confirmed the bundle contains a swagger.yml entry), and it's what app/app.go:2772 RegisterSwaggerAPI mounts at /swagger/ via fs.NewWithNamespace("swagger"). Since statik.go is unchanged in this PR, the running node's swagger UI will still advertise /ibc/apps/interchain_accounts/host/v1/params for an endpoint that no longer exists.
Re-running scripts/update-swagger-ui-statik.sh to regenerate docs/swagger/statik.go would make the change reach the served docs. Non-blocking — docs-only, no runtime or consensus impact — and note the embedded copy may already have been drifting from this file before this PR, in which case this is pre-existing rather than newly introduced. Either way, the removal doesn't propagate without the regen.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3881 +/- ##
==========================================
- Coverage 61.61% 60.75% -0.87%
==========================================
Files 2348 2254 -94
Lines 200842 190346 -10496
==========================================
- Hits 123751 115646 -8105
+ Misses 66033 64479 -1554
+ Partials 11058 10221 -837
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
* main: test(config): complete the GetConfig read-site coverage (PLT-893) (#3870) Remove interchain swagger API and protos (#3881) fix(flatkv): preserve empty misc values and reject malformed empty node imports (#3869) fix(evm): count post-admission apply failures in dynamic base-fee gas (CON-359) (#3871) scripts: load generator for arctic-1 and atlantic-2 (#3850) Update go-releaser heading with experimental notice (#3879) fix(evmrpc): stream request-body budget charging to close slowloris gap (PLT-780) (#3836) Remove unused interchain accounts implementation (#3875) test(config): extend golden value test coverage (PLT-893) (#3861) Update v6.6 changelog in prep to cut patch release (#3876) Close temporary rootmulti store in connection types setup (#3872) Restore LCD pagination while preserving v6.6 precompile semantics (#3867)
Now that interchain accounts is deleted, remove the proto and swagger APIs. This breaking change in proto + APIs is expected since in and out bound IBC is disabled.