-
Notifications
You must be signed in to change notification settings - Fork 144
Merge v3.14.0-beta-1 to main! #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: [AC-1497](https://sendbird.atlassian.net/browse/AC-1497) ### Changelogs - Added 'wide' and 'full' width support for `MessageContent` when value exists in `message.extendedMessagePayload['ui']['container_type']` [AC-1497]: https://sendbird.atlassian.net/browse/AC-1497?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…nt-family to template root (#1022) ### Changelogs - Fixed a bug where swiping carousel in mobile view displaying flickering effect - Added missing default font-family value to template root
…me spec changes (#1032) Fixes: [AC-1230](https://sendbird.atlassian.net/browse/AC-1230) - 카루셀을 UIKit 에서 빼고 Core 쪽으로 옮긴다. - 카루셀은 View style 무시, container type 무시 (미래에 요청 있을 때 오픈) - container type full 은 뺀다 => default, wide 만 지원한다 => 지원 없는 container type 을 받으면 default 로 그려준다. - template version validation 을 추가한다. ### Changelogs - Removed `Carousel` ui component as message template returns carousel component instead - Container type 'full' is no longer supported due to inconsistent default style of parent template components with other types - Added template version validation. If template's version is unsupported, fallback message will be rendered instead. [AC-1230]: https://sendbird.atlassian.net/browse/AC-1230?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Ahyoung Ryu <irene.ryu@sendbird.com>
Added error catch in malformed template payload --------- Co-authored-by: Ahyoung Ryu <irene.ryu@sendbird.com>
1. Carousel templates created with direct simple templates in items (no reservations keys) should be suppported as fallback logic. 2. timestamp location of carousel template body must be dynamically updated. 3. For composite template, template version should be max of (composite + its simple templstes).
Fixes: - [AC-1824](https://sendbird.atlassian.net/browse/AC-1824) 1. fix default profile not showing issue 2. fix scroll displayed in message sender title container [AC-1824]: https://sendbird.atlassian.net/browse/AC-1824?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…ithout reservation key (#1038) - Fix bug where argb conversion step is skipped for carousel without reservation key - string to numeric conversion skipped
Co-authored-by: Baek EunSeo <hoon@sendbird.com>
HoonBaek
approved these changes
Apr 5, 2024
Contributor
HoonBaek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[v3.14.0] (Apr 5, 2024)
Feature
TemplateMessageItemBodynow supportsCarouselViewtype templateMessageContentwhen value exists inmessage.extendedMessagePayload['ui']['container_type']TemplateMessageItemBodyMessage template fixes/updates
borderRadius,backgroundColor, andcolorfor message template itemsOther fixes