[UK-932]Integrate message threading #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add class names of MessageItemMenu * Change the message status design to row * Apply that replyTypeFilter is changed to replyType in core sdk * Add onLoad and onError props in ImageRenderer component * Change opacity and icon display of QuoteMessage * Move QuoteMessage into the MessageContent * Fix the center align of IconButton * Update core min.js file * Update snapshot * Update class name of menu items
* Add a quote message as a param of onBeforeSendUserMessage and onBeforeSendFileMessage * Add a quoteMessage as a prop of the renderMessageInput props
Create container containing message item body and emoji reactions components to match width of them
* Turn on the reply and the image compression feature on the user2 Turn off the image compression feature on the user3 * Apply scrollToMessage into QuoteMessage component
* Fix typo of isReplyToChannel * Ignore '*' in the customTypes of messageListParams because it's inserted from chat sdk
* Set includeThreadInfo to true when replyType is 'quote_reply'
* Add Icon color type gray and apply it for video play button * Add a color theme and use it for tooltip background color
* Apply position properties on quote message input component
* Add string set 'Reply to message' and show it when quote message is attached into message input component
* Remove sendbird.min.js file and import released core sdk * Update snapshot * Fix message list params filter condition about customTypes * [QU-309] Do not update last message if message id doesn't match (#47) * [QU-299] Fix layout of QuoteMesssageInput component when it is file message * Add channel event management logic for onThreadInfoUpdated * [QU-336][1] Remove the gap created by the minus bottom position * [QU-336][2] Fix layout of message input in the message input wrapper component * Fix message list params condition * Use optional chaning in js * Add test codes for ON_MESSAGE_THREAD_INFO_UPDATE event
sravan-s
reviewed
Nov 8, 2021
sravan-s
reviewed
Nov 8, 2021
sravan-s
reviewed
Nov 8, 2021
sravan-s
reviewed
Nov 8, 2021
…hes message sender
sravan-s
reviewed
Nov 16, 2021
sravan-s
reviewed
Nov 16, 2021
| if (!duplicatedMessage) { | ||
| return msg; | ||
| } | ||
| duplicatedMessageIds.push(duplicatedMessage.messageId); |
Contributor
There was a problem hiding this comment.
I might have a suggestion for this
sravan-s
approved these changes
Nov 16, 2021
Contributor
sravan-s
left a comment
sravan-s
left a comment
There was a problem hiding this comment.
LGTM, need to discuss small changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UK-932
Description Of Changes
Add a brief description of the changes that you have involved in this PR
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_