Skip to content

Add LICENSE and tests to sdist #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

Add LICENSE and tests to sdist #155

merged 1 commit into from
Aug 7, 2019

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Aug 1, 2019

Closes #154

@seperman
Copy link
Owner

seperman commented Aug 3, 2019

Hi @jayvdb
Thanks for making the PR! Do you think we need to include the test files in the distribution? I usually only include the minimal that is needed to run the package.

@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 4, 2019

Tests in the source distribution are highly desirable.
The tests wont be included in the wheel, which is what 'normal' users will consume these days.

@seperman seperman merged commit 00b8c11 into seperman:dev Aug 7, 2019
@seperman
Copy link
Owner

seperman commented Aug 7, 2019

Thanks @jayvdb
I will close the ticket once this is published on Pypi.

@jayvdb jayvdb mentioned this pull request Oct 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jayvdb @seperman