Skip to content

Fix for Python 3.10 and 10: don't compare sys.version string #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Fix for Python 3.10 and 10: don't compare sys.version string #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
974c5f3
Merge pull request #162 from seperman/dev
seperman Oct 18, 2019
c8e61d1
Merge pull request #165 from seperman/dev
seperman Nov 8, 2019
68177e8
Fix for Python 3.10 and 10: don't compare sys.version string
hugovk Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions deepdiff/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@

logger = logging.getLogger(__name__)

py_major_version = sys.version[0]
py_minor_version = sys.version[2]
py_major_version = sys.version_info.major

py2 = py_major_version == '2'
py3 = py_major_version == '3'
py4 = py_major_version == '4'
py2 = py_major_version == 2
py3 = py_major_version == 3
py4 = py_major_version == 4

if py4:
logger.warning('Python 4 is not supported yet. Switching logic to Python 3.') # pragma: no cover
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import sys
from setuptools import setup

if sys.version[0] == '2': # pragma: no cover
if sys.version_info.major[0] == 2: # pragma: no cover
sys.exit('Python 2 is not supported anymore. The last version of DeepDiff that supported Py2 was 3.3.0')

# if you are not using vagrant, just delete os.link directly,
Expand Down