refactor: bundle process_chromosome_batch params into config structs#103
Open
refactor: bundle process_chromosome_batch params into config structs#103
Conversation
Replace the 18 positional parameters of process_chromosome_batch() with two Copy config structs — BatchConfig (scalars + BAM path) and BatchResources (shared indices, mappings, and accumulator config) — so call sites are self-documenting and adding a new parameter no longer shuffles the positional list. Closes #85 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_chromosome_batch()insrc/rna/dupradar/counting.rspreviously took 18 positional parameters, so call sites were hard to read and prone to argument-order bugs (flagged in refactor: bundle process_chromosome_batch() parameters into config structs #85).Copyconfig structs:BatchConfig<'a>— scalars and the BAM path (bam_path,reference,stranded,paired,htslib_threads).BatchResources<'a>— shared read-only data (chromosome name table, spatial index, chromosome mapping/prefix, biotype lookup, RSeQC + Qualimap config).#[allow(clippy::too_many_arguments)].Closes #85
Test plan
cargo checkcargo clippy --all-targets -- -D warningscargo test --lib(200/200 pass)🤖 Generated with Claude Code