Conversation
- Rename CLI 'bam' argument to 'input', accepting SAM/BAM/CRAM files - Add --reference/-r option for specifying CRAM reference FASTA - Call set_reference() on all htslib readers when reference is provided - Add early validation for CRAM input without reference or REF_PATH - Update all error messages, log output, and doc comments to be format-agnostic - Rename bam_to_gtf_mapping() to alignment_to_gtf_mapping() - Add SAM integration test verifying identical output to BAM - Add --reference coverage to CLI unit test - Update README, CHANGELOG, CONTRIBUTING, and benchmark docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--reference/-rCLI option for specifying a CRAM reference FASTA, with early validation when missingChanges
CLI (
src/cli.rs)bampositional argument toinput(accepts SAM/BAM/CRAM)--reference/-roption for CRAM reference FASTACore (
src/counting.rs)reference: Option<&str>throughcount_reads()andprocess_chromosome_batch()set_reference()on all htslib readers when a reference is providedEntry point (
src/main.rs)--referenceorREF_PATHenv varbam_stem→input_stem, update log messagesConfig (
src/config.rs)bam_to_gtf_mapping()→alignment_to_gtf_mapping()Tests
test_sam_input_matches_bam) verifying identical output to BAMtests/data/test.samtest fixture--referenceflag coverage in CLI unit testDocumentation