fix: scope rustflags to target triple to avoid SIGILL in build scripts#91
Merged
fix: scope rustflags to target triple to avoid SIGILL in build scripts#91
Conversation
The previous fix (#90) switched from RUSTFLAGS to build.rustflags, but build.rustflags still applies to build scripts. Use target-scoped rustflags (target.'<triple>'.rustflags) so CPU flags only affect crate compilation, leaving host build scripts unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.rustflagsfrom fix: use build.rustflags config to avoid SIGILL in SIMD builds #90 still applies to build scripts, so the AVX-512 SIGILL persiststarget.'<triple>'.rustflagswhich only affects compilation for the specified target, leaving host build scripts unaffectedTest plan
🤖 Generated with Claude Code