Skip to content

Conversation

@justinegeffen
Copy link
Contributor

@justinegeffen justinegeffen commented Jan 22, 2025

  • Added breaking change content to describe new Spot retries behavior.
  • Troubleshooting content to follow.

Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 12ca673
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/679d16af6d424b000861d5bd
😎 Deploy Preview https://deploy-preview-401--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justinegeffen justinegeffen marked this pull request as draft January 22, 2025 19:51
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my confused comments.

I'm actually unsure if this is referring to

  • this change, where spot retries were disabled (and defaults added for maxRetries and errorStrategy
  • or this change only, where errorStrategy and maxRetries were reset to default.

Assuming it's the latter, we don't need to mention any maxSpotAttempts, except in a general helpful sense.

@justinegeffen
Copy link
Contributor Author

  • this change

Thanks @pinin4fjords, great question. I believe we're referring to both in that this release included a reversion of the previous change and required more detailed documentation.

Is this accurate as a breaking change notice? Alternatively, we could remove this and create a troubleshooting article instead which we can cross-link to the release notes.

@pinin4fjords
Copy link
Member

pinin4fjords commented Jan 24, 2025

  • this change

Thanks @pinin4fjords, great question. I believe we're referring to both in that this release included a reversion of the previous change and required more detailed documentation.

Is this accurate as a breaking change notice? Alternatively, we could remove this and create a troubleshooting article instead which we can cross-link to the release notes.

@justinegeffen What I mean is, the second change isn't a full reversion of the first. maxSpotAttempts was only impacted in the first, not the second, may not need mentioning here.

justinegeffen and others added 3 commits January 28, 2025 21:54
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen justinegeffen added 1. Editor review Needs a language review 1. Dev/PM/SME Needs a review by a Dev/PM/SME labels Jan 28, 2025
@justinegeffen justinegeffen marked this pull request as ready for review January 29, 2025 08:48
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment but I'm generally happy with this.

justinegeffen and others added 2 commits January 31, 2025 20:28
Co-authored-by: Jonathan Manning <pininforthefjords@gmail.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen justinegeffen mentioned this pull request Jan 31, 2025
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen justinegeffen added 3. Reviews complete Reviews complete. Remove label when confirmed in prod. and removed 1. Editor review Needs a language review 1. Dev/PM/SME Needs a review by a Dev/PM/SME labels Jan 31, 2025
@justinegeffen justinegeffen merged commit b89c73f into master Feb 3, 2025
7 checks passed
@justinegeffen justinegeffen deleted the justinegeffen-errorstrategy branch February 3, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. Reviews complete Reviews complete. Remove label when confirmed in prod.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants