-
Notifications
You must be signed in to change notification settings - Fork 5
Added errorStrategy breaking change to cloud changelog #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for my confused comments.
I'm actually unsure if this is referring to
- this change, where spot retries were disabled (and defaults added for
maxRetriesanderrorStrategy - or this change only, where
errorStrategyandmaxRetrieswere reset to default.
Assuming it's the latter, we don't need to mention any maxSpotAttempts, except in a general helpful sense.
Thanks @pinin4fjords, great question. I believe we're referring to both in that this release included a reversion of the previous change and required more detailed documentation. Is this accurate as a breaking change notice? Alternatively, we could remove this and create a troubleshooting article instead which we can cross-link to the release notes. |
@justinegeffen What I mean is, the second change isn't a full reversion of the first. |
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
adamrtalbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment but I'm generally happy with this.
Co-authored-by: Jonathan Manning <pininforthefjords@gmail.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.