Skip to content

chore: port wave CI to push to internal ECR SEC-1395#1039

Merged
ShahzebMahmood merged 5 commits into
masterfrom
port-wave-ci-internal-ecr-SEC-1395
May 11, 2026
Merged

chore: port wave CI to push to internal ECR SEC-1395#1039
ShahzebMahmood merged 5 commits into
masterfrom
port-wave-ci-internal-ecr-SEC-1395

Conversation

@ShahzebMahmood
Copy link
Copy Markdown
Contributor

@ShahzebMahmood ShahzebMahmood commented May 5, 2026

Summary

  • ported wave CI to push to the new internal ECR alongside the legacy one
  • tag-and-push.sh switched from jib (push) to jibDockerBuild (local) so the workflow handles all pushes
  • legacy pushes (wave/app and nf-tower-enterprise/wave) preserved on [release] commits; new internal pushes go to internal/seqeralabs/wave/app and platform/wave

@ShahzebMahmood ShahzebMahmood self-assigned this May 5, 2026
@ShahzebMahmood
Copy link
Copy Markdown
Contributor Author

@bebosudo just wanted to check the below thing i came across:

  1. wave is public but seqeralabs/actions is private with access limited to internal/private repos. so the seqeralabs/actions/push step fails to resolve. options: inline the action's logic here, make seqeralabs/actions public, or change wave's visibility. leaning towards inlining, any preference?
  2. is platform/wave the right path for the new enterprise push, or different name?

@ShahzebMahmood
Copy link
Copy Markdown
Contributor Author

Per the discussion in #private-devops (https://seqera.slack.com/archives/C085RGMMU68/p1778138691159789?thread_ts=1778074434.502459): wave is public and seqeralabs/actions is private, so the push action can't resolve.

Team agreed to inline the push logic for now and revisit once the actions repo is split out (SEC-1409). Inlined both seqeralabs/actions/push calls in 495c3e0 with comments in the workflow pointing at the original action SHA so we know where to revert.

CI should pass now since "Unable to resolve action 'seqeralabs/actions'" was the only blocker.

@ShahzebMahmood ShahzebMahmood marked this pull request as ready for review May 8, 2026 15:40
@ShahzebMahmood ShahzebMahmood requested review from bebosudo May 8, 2026 15:41
Copy link
Copy Markdown
Member

@bebosudo bebosudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the wave repo release policy: each time a commit with [release] in the message is merged we build and push an image for enterprise customers as well?

one important change is required when pushing the image to the new enterprise location, LGTM otherwise

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@ShahzebMahmood
Copy link
Copy Markdown
Contributor Author

@bebosudo yeah, seems so from previous workflow launches. Last release was [release] v1.33.3 on 2026-04-28 and the image got pushed to nf-tower-enterprise/wave:v1.33.3 on the legacy ECR.

ShahzebMahmood and others added 4 commits May 11, 2026 08:07
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
@ShahzebMahmood ShahzebMahmood force-pushed the port-wave-ci-internal-ecr-SEC-1395 branch from 8a60e4c to 836bec4 Compare May 11, 2026 12:11
@ShahzebMahmood ShahzebMahmood merged commit 9df3340 into master May 11, 2026
4 checks passed
@ShahzebMahmood ShahzebMahmood deleted the port-wave-ci-internal-ecr-SEC-1395 branch May 11, 2026 12:40
pditommaso added a commit that referenced this pull request May 17, 2026
This reverts commit 9df3340.

The release flow in #1039 split JIB build from push (jibDockerBuild + docker
push), but the non-enterprise gradle invocation did not pass -PjibRepo, so JIB
tagged the image as wave/app:1.33.5 (from VERSION) while the script then tried
to re-tag wave/app:v1.33.5 (TAG=v + VERSION) -- breaking the release job in
run 25995019680.

Build.yml conflict resolution preserves ff8c7af (gating on detect-release
output) and drops the now-orphaned "id: release" since no surviving step
consumes steps.release.outputs.version.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants