Disable travis builds using nightly rustc.#239
Merged
bors-servo merged 1 commit intomasterfrom Mar 27, 2020
Merged
Conversation
Member
Author
|
r? @asajeffrey |
asajeffrey
approved these changes
Mar 26, 2020
asajeffrey
left a comment
asajeffrey
left a comment
There was a problem hiding this comment.
You can r=me, the suggestion is a just a suggestion.
| language: rust | ||
| rust: | ||
| - nightly | ||
| #- nightly |
There was a problem hiding this comment.
Might be worth using if [ $TRAVIS_RUST_VERSION == "stable"] on rustfmt rather than just disabling nightly?
Member
Author
There was a problem hiding this comment.
rustc warns about things in the generated jsapi bindings. When these don't have rustfmt applied to them, the entire contents of the file appears on one line which exceeds the travisci log limit and the build fails. We can't build without rustfmt, sadly.
Member
Author
|
@bors-servo r+ |
Contributor
|
📌 Commit 19aa712 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're prevented from merging any changes as long as there's no rustfmt available on nightly (https://rust-lang.github.io/rustup-components-history/).