serializer: Simplify a bit number serialization. #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #410
Member
Author
|
(These are just review comments that I'm applying on top of the previous patch) |
mrobinson
approved these changes
Nov 29, 2025
| }; | ||
| if let Some(v) = int_value { | ||
| return write!(dest, "{}", v); | ||
| } |
Member
There was a problem hiding this comment.
Could be expressed slightly more succinctly inline:
Suggested change
| } | |
| if let Some(v) = int_value { | |
| return write!(dest, "{v}"); | |
| } |
Member
Author
There was a problem hiding this comment.
Gah, auto-merge was faster...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #410