Skip to content

ci: simplified CI workflow and removed unnecessary miri script - #467

Merged
jdm merged 3 commits into
servo:v2from
alejandro-vaz:simple-ci
Aug 28, 2026
Merged

ci: simplified CI workflow and removed unnecessary miri script#467
jdm merged 3 commits into
servo:v2from
alejandro-vaz:simple-ci

Conversation

@alejandro-vaz

@alejandro-vaz alejandro-vaz commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

this PR tweaks the CI workflow to only install components on the fly when needed instead of for all versions

additionally, it installs miri directly

it doesn't seem to be substantially faster, but it looks like there are some improvements on the nightly job

the old miri script was deleted

@alejandro-vaz alejandro-vaz self-assigned this Aug 28, 2026
@alejandro-vaz
alejandro-vaz requested a review from jdm August 28, 2026 07:18
@alejandro-vaz alejandro-vaz added this to the v2-alpha.13 milestone Aug 28, 2026
@alejandro-vaz
alejandro-vaz marked this pull request as ready for review August 28, 2026 07:18

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear about some coverage that is being removed:

  • we no longer explicitly verify that --no-default-features works, but we don't actually have default features
  • we will fail CI if miri is unavailable for any given nightly toolchain that we use
  • we now run benchmarks with all features enabled instead of the default features
  • we only run miri with all features enabled

I feel like these are reasonable simplifications, but I just wanted to call them out.

@jdm
jdm added this pull request to the merge queue Aug 28, 2026
Merged via the queue into servo:v2 with commit 6b48834 Aug 28, 2026
6 checks passed
@alejandro-vaz

Copy link
Copy Markdown
Collaborator Author

yeah, those are reasonable simplifications

  • not having default features means we can simply remove that step
  • miri is usually always shipped with nightly these days
  • running benchmarks with all features allows us to benchmark those features if necessary (will work on it with add integration tests #440)
  • same with miri for all features enabled, it allows us to test those features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants