ci: simplified CI workflow and removed unnecessary miri script - #467
Merged
Conversation
jdm
approved these changes
Aug 28, 2026
jdm
left a comment
Member
There was a problem hiding this comment.
Just to be clear about some coverage that is being removed:
- we no longer explicitly verify that --no-default-features works, but we don't actually have default features
- we will fail CI if miri is unavailable for any given nightly toolchain that we use
- we now run benchmarks with all features enabled instead of the default features
- we only run miri with all features enabled
I feel like these are reasonable simplifications, but I just wanted to call them out.
Collaborator
Author
|
yeah, those are reasonable simplifications
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR tweaks the CI workflow to only install components on the fly when needed instead of for all versions
additionally, it installs miri directly
it doesn't seem to be substantially faster, but it looks like there are some improvements on the nightly job
the old miri script was deleted