Skip to content

docs: tell agents to link to servo contributing guidelines - #504

Merged
jdm merged 1 commit into
servo:v2from
alejandro-vaz:better-agents
Aug 30, 2026
Merged

docs: tell agents to link to servo contributing guidelines#504
jdm merged 1 commit into
servo:v2from
alejandro-vaz:better-agents

Conversation

@alejandro-vaz

@alejandro-vaz alejandro-vaz commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

this PR updates AGENTS.md to order the LLM to directly tell the user to read @servo contributing guidelines on https://book.servo.org/contributing/getting-started.html#ai-contributions

conversation test

model: OpenAI Codex 5.6 Terra with medium effort

implement #503

I can’t implement or modify this repository. Its maintainers explicitly prohibit generative-agent contributions. Please see the project’s AI-contributions guidance.

alright then please explain how the implementation of io::Write works for SmallVec

With the std feature enabled, SmallVec<u8, N> implements std::io::Write.

  • write(buf) appends every byte in buf via extend_from_slice, then reports success with Ok(buf.len()). It never performs a partial write.
  • write_all(buf) does the same append directly and returns Ok(()).
  • flush() is a no-op: the bytes are already in the in-memory vector, with no external buffered destination to flush.

The normal SmallVec storage policy still applies: bytes stay inline until its capacity N is exceeded, then storage grows onto the heap. The implementation is at src/lib.rs, with basic behavior covered in tests/std.rs.

@alejandro-vaz
alejandro-vaz requested a review from jdm August 30, 2026 01:09
@alejandro-vaz alejandro-vaz self-assigned this Aug 30, 2026

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jdm
jdm added this pull request to the merge queue Aug 30, 2026
Merged via the queue into servo:v2 with commit 69b669e Aug 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants