Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added etc/ci/performance downloads to .gitignore. #13248

Merged
merged 1 commit into from Sep 26, 2016

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Sep 12, 2016

Added the files downloaded for etc/ci/performance to .gitignore, which gets rid of lot of spurious reporting from git status.

r? @shinglyu


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's about git

This change is Reviewable

.gitignore Outdated
@@ -8,6 +8,7 @@
/ports/android/obj
/python/_virtualenv
/python/tidy/servo_tidy.egg-info
/etc/ci/performance/page_load_test

This comment has been minimized.

Copy link
@shinglyu

shinglyu Sep 22, 2016

Member

How about adding this to the etc/ci/performance/.gitignore instead? If someday we want to move the etc/ci/performance folder we don't need to remember to edit this top level gitignore.

This comment has been minimized.

Copy link
@asajeffrey

asajeffrey Sep 22, 2016

Author Member

Done.

@asajeffrey asajeffrey force-pushed the asajeffrey:etc-ci-performance-gitignore branch from 5cd07be to ac59f56 Sep 22, 2016
@shinglyu

This comment has been minimized.

Copy link
Member

shinglyu commented Sep 26, 2016

I don't believe the Travis error are related to this patch. @bors-servo r+

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Sep 26, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 26, 2016

📌 Commit ac59f56 has been approved by Manishearth

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Sep 26, 2016

@bors-servo r=shinglyu

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 26, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13372
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 26, 2016

📌 Commit ac59f56 has been approved by shinglyu

@highfive highfive assigned shinglyu and unassigned Manishearth Sep 26, 2016
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 26, 2016

⌛️ Testing commit ac59f56 with merge 58e6d7b...

bors-servo added a commit that referenced this pull request Sep 26, 2016
…nglyu

Added etc/ci/performance downloads to .gitignore.

<!-- Please describe your changes on the following line: -->

Added the files downloaded for `etc/ci/performance` to `.gitignore`, which gets rid of lot of spurious reporting from `git status`.

r? @shinglyu

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's about git

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13248)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Sep 26, 2016

@bors-servo bors-servo merged commit ac59f56 into servo:master Sep 26, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.