Bootstrap from more permanent URLs by SimonSapin · Pull Request #18942 · servo/servo

SimonSapin · 2017-10-18T17:27:15Z

The rust-lang-ci S3 bucket is ephemeral. static-rust-lang-org.s3.amazonaws.com is not going away soon, but using static.rust-lang.org when possible keeps things working if it ever does.

https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062
https://internals.rust-lang.org/t/public-stable-rust-services/6072

We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step.

This change is

The `rust-lang-ci` S3 bucket is ephemeral: https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062 https://internals.rust-lang.org/t/public-stable-rust-services/6072 We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step.

mbrubeck · 2017-10-18T17:28:19Z

@bors-servo r+

bors-servo · 2017-10-18T17:28:20Z

📌 Commit efdaa0d has been approved by mbrubeck

mbrubeck · 2017-10-18T21:17:16Z

@bors-servo r+

bors-servo · 2017-10-18T21:17:16Z

📌 Commit 664f282 has been approved by mbrubeck

mbrubeck · 2017-10-18T22:52:04Z

@bors-servo r+

bors-servo · 2017-10-18T22:52:04Z

📌 Commit a931d3b has been approved by mbrubeck

bors-servo · 2017-10-19T09:13:01Z

⌛ Testing commit a931d3b with merge 3beb62b...

Bootstrap from more permanent URLs The `rust-lang-ci` S3 bucket is ephemeral. `static-rust-lang-org.s3.amazonaws.com` is not going away soon, but using `static.rust-lang.org` when possible keeps things working if it ever does. https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062 https://internals.rust-lang.org/t/public-stable-rust-services/6072 We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18942)

bors-servo · 2017-10-19T09:29:40Z

💔 Test failed - windows-msvc-dev

SimonSapin · 2017-10-19T09:33:41Z

URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)>

  File "c:\buildbot\slave\windows-msvc-dev\build\python\servo\build_commands.py", line 233, in build
    self.ensure_bootstrapped(target=target)
  File "c:\buildbot\slave\windows-msvc-dev\build\python\servo\command_base.py", line 618, in ensure_bootstrapped
    stable=self._use_stable_rust)
  File "c:\buildbot\slave\windows-msvc-dev\build\python\_virtualenv\Lib\site-packages\mach\registrar.py", line 123, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "c:\buildbot\slave\windows-msvc-dev\build\python\_virtualenv\Lib\site-packages\mach\registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "c:\buildbot\slave\windows-msvc-dev\build\python\servo\bootstrap_commands.py", line 97, in bootstrap_rustc
    nightly_commit_hash = toml.load(urllib2.urlopen(channel))["pkg"]["rustc"]["git_commit_hash"]
  File "C:\Python27\lib\urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "C:\Python27\lib\urllib2.py", line 431, in open
    response = self._open(req, data)
  File "C:\Python27\lib\urllib2.py", line 449, in _open
    '_open', req)
  File "C:\Python27\lib\urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "C:\Python27\lib\urllib2.py", line 1240, in https_open
    context=self._context)
  File "C:\Python27\lib\urllib2.py", line 1197, in do_open
    raise URLError(err)

Retrying in case this an intermittent network error, though it could also be that Python on this Windows builder is not configure with the appropriate root certificates to verify static.rust-lang.org.

@bors-servo retry

SimonSapin · 2017-10-19T11:00:23Z

@bors-servo r-

SimonSapin · 2017-10-19T11:04:57Z

Based on messing around with salt:

Our Mac builders have Python 2.7.13 with ssl.HAS_SNI == True, and connecting to static.rust-lang.org works.
Our Linux builders have Python 2.7.6 without a ssl.HAS_SNI attribute, so this PR uses the fallback hostname which works.
Our Windows builders have Python 2.7.12 with ssl.HAS_SNI == True, and fail to verify the certificate when connecting to static.rust-lang.org. This may or may not be related to SNI.

SimonSapin · 2017-10-19T15:22:20Z

Our Windows builders have Python 2.7.12 with ssl.HAS_SNI == True, and fail to verify the certificate when connecting to static.rust-lang.org. This may or may not be related to SNI.

These Windows builders can successfully connect to https://static-rust-lang-org.s3.amazonaws.com/

jdm · 2017-10-19T17:59:20Z

@bors-servo: r=jdm,mbrubeck
yakkety sax plays in the distance

bors-servo · 2017-10-19T17:59:20Z

📌 Commit 404c722 has been approved by jdm,mbrubeck

bors-servo · 2017-10-19T18:09:28Z

⌛ Testing commit 404c722 with merge ce5488e...

Bootstrap from more permanent URLs The `rust-lang-ci` S3 bucket is ephemeral. `static-rust-lang-org.s3.amazonaws.com` is not going away soon, but using `static.rust-lang.org` when possible keeps things working if it ever does. https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062 https://internals.rust-lang.org/t/public-stable-rust-services/6072 We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18942)

bors-servo · 2017-10-19T18:48:30Z

💔 Test failed - arm32

jdm · 2017-10-19T19:35:56Z

@bors-servo: retry

maybe the virtualenv is busted?

bors-servo · 2017-10-19T19:50:16Z

⌛ Testing commit 404c722 with merge 5e87ed418080fd54b1a8e6cbd0874901c9f525ea...

bors-servo · 2017-10-19T20:43:32Z

💔 Test failed - linux-rel-css

mbrubeck · 2017-10-19T20:55:48Z

Details

Error running mach:

    ['test-css', '--release', '--processes', '16', '--log-raw', 'test-css.log', '--log-errorsummary', 'css-errorsummary.log', '--always-succeed']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'module' object has no attribute 'QueuedProxyLogger'

  File "/home/servo/buildbot/slave/linux-rel-css/build/python/servo/testing_commands.py", line 618, in test_css
    ret = self.run_test_list_or_dispatch(kwargs["test_list"], "css", self._test_css, **kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/python/servo/testing_commands.py", line 443, in run_test_list_or_dispatch
    return correct_function(**kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/python/servo/testing_commands.py", line 626, in _test_css
    return self.wptrunner(run_file, **kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/python/servo/testing_commands.py", line 484, in wptrunner
    return run_globals["run_tests"](**kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/run_css.py", line 13, in run_tests
    return run.run_tests(paths=paths, **kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/run.py", line 46, in run_tests
    success = wptrunner.run_tests(**kwargs)
  File "/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/wptrunner.py", line 181, in run_tests
    env_extras) as test_environment:
  File "/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/environment.py", line 104, in __enter__
    self.setup_server_logging()
  File "/home/servo/buildbot/slave/linux-rel-css/build/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/environment.py", line 171, in setup_server_logging
    server_logger = proxy.QueuedProxyLogger(server_logger)
program finished with exit code 1

jdm · 2017-10-20T00:12:42Z

@bors-servo: retry

Update mozlog dependency #18961

bors-servo · 2017-10-20T12:44:28Z

⌛ Testing commit 404c722 with merge 041bd62...

Bootstrap from more permanent URLs The `rust-lang-ci` S3 bucket is ephemeral. `static-rust-lang-org.s3.amazonaws.com` is not going away soon, but using `static.rust-lang.org` when possible keeps things working if it ever does. https://internals.rust-lang.org/t/updates-on-rusts-ci-uploads/6062 https://internals.rust-lang.org/t/public-stable-rust-services/6072 We’ll still need to find a solution for "alt" rustc builds. In the meantime, this is a step.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18942)

bors-servo · 2017-10-20T13:49:05Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm,mbrubeck
Pushing 041bd62 to master...

highfive assigned mbrubeck Oct 18, 2017

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 18, 2017

SimonSapin added 2 commits October 18, 2017 22:45

Bootstrap: print URLs being downloaded.

1f4c0c6

Bootstrap from official static.rust-lang.org when SNI is available

664f282

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 18, 2017

SimonSapin changed the title ~~Download "non-alt" rustc builds from more permanent URLs~~ Bootstrap from more permanent URLs Oct 18, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 18, 2017

Use servo-deps AWS S3 bucket instead of rust-lang-ci for OpenSSL

a931d3b

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 18, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 18, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 19, 2017

Only pass cafile argument to urlopen in Python versions that support it.

404c722

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 19, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 19, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 19, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 19, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 19, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 20, 2017

bors-servo merged commit 404c722 into master Oct 20, 2017

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 20, 2017

SimonSapin deleted the static.rlo branch October 20, 2017 15:23

Uh oh!

Conversation

SimonSapin commented Oct 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbrubeck commented Oct 18, 2017

Uh oh!

bors-servo commented Oct 18, 2017

Uh oh!

mbrubeck commented Oct 18, 2017

Uh oh!

bors-servo commented Oct 18, 2017

Uh oh!

mbrubeck commented Oct 18, 2017

Uh oh!

bors-servo commented Oct 18, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

SimonSapin commented Oct 19, 2017

Uh oh!

SimonSapin commented Oct 19, 2017

Uh oh!

SimonSapin commented Oct 19, 2017

Uh oh!

SimonSapin commented Oct 19, 2017

Uh oh!

jdm commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

jdm commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

bors-servo commented Oct 19, 2017

Uh oh!

mbrubeck commented Oct 19, 2017

Uh oh!

jdm commented Oct 20, 2017

Uh oh!

bors-servo commented Oct 20, 2017

Uh oh!

bors-servo commented Oct 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SimonSapin commented Oct 18, 2017 •

edited

Loading