Add initial support for BlitFramebuffer#26288
Closed
imiklos wants to merge 1 commit intoservo:masterfrom
Closed
Conversation
Member
|
@bors-servo try=wpt |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 23, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
jdm
requested changes
Apr 23, 2020
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
We should also check for integer overflow for the rectangles per https://www.khronos.org/registry/webgl/specs/latest/2.0/#5.40 .
| const DEPTH_STENCIL = Self::DEPTH.bits | Self::STENCIL.bits; | ||
| } | ||
| }; | ||
| let bits = BlitFrameBufferFlags::from_bits(mask).unwrap(); |
Member
There was a problem hiding this comment.
Instead of unwrapping, we should probably set an InvalidValue error and return.
| let bits = BlitFrameBufferFlags::from_bits(mask).unwrap(); | ||
| let attributes = self.base.GetContextAttributes().unwrap(); | ||
|
|
||
| if bits.contains(BlitFrameBufferFlags::DEPTH_STENCIL) { |
Member
There was a problem hiding this comment.
We should use intersect instead of contains.
| return self.base.webgl_error(InvalidOperation); | ||
| } | ||
|
|
||
| if dst_x0 != src_x0 || dst_x1 != src_x1 || dst_y0 != src_y0 || dst_y1 != src_y1 { |
Member
There was a problem hiding this comment.
This looks like we reject any blit where the source rectangle is different from the dest rectangle. Where in the WebGL or OpenGLES specifications is that specified?
Author
There was a problem hiding this comment.
I was used this for testing purpose, unfortunately it's left behind. I will remove it.
Member
|
@bors-servo try=wpt-mac retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 23, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Member
|
Adjusting the test expectations to match what CI reports is the best choice. |
Contributor
|
💔 Test failed - status-taskcluster |
imiklos
force-pushed
the
blit_framebuffer
branch
from
d53df02 to
ff8f3e8
Compare
Author
|
@jdm Thank you! I've updated the pull request with the changes you mentioned, and updated the test expectations from the CI reports (linux). |
Member
|
@bors-servo try=wpt |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
@bors-servo try=wpt-mac retry |
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
Contributor
|
💔 Test failed - status-taskcluster |
imiklos
force-pushed
the
blit_framebuffer
branch
from
ff8f3e8 to
51e3914
Compare
Author
|
I've updated the test expectations according to the CI. |
Member
|
@bors-servo try=wpt retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 28, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
@bors-servo retry try=wpt-mac |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 28, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
Unfortunately the failures in /_webgl/conformance2/rendering/blitframebuffer-filter-srgb.html show that this is another test that is including pixel values in the error messages, and the pixels seem to include uninitialized memory in our implementation right now. |
Member
|
/_webgl/conformance2/renderbuffers/multisampled-depth-renderbuffer-initialization.html and /_webgl/conformance2/renderbuffers/multisampled-stencil-renderbuffer-initialization.html and multisampled-renderbuffer-initialization.html also report different failures on macOS. |
Add initial support for the WebGL2 BlitFramebuffer call.
imiklos
force-pushed
the
blit_framebuffer
branch
from
51e3914 to
131c5b1
Compare
Author
|
I've updated the test expectations again, hope it will be good now. 🙏 😄 |
Member
|
@bors-servo try=wpt |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
@bors-servo try=wpt-mac retry |
Contributor
bors-servo
added a commit
that referenced
this pull request
Apr 30, 2020
Add initial support for BlitFramebuffer Add initial support for the WebGL2 `BlitFramebuffer` call. --- Note: After I've rebased my patch to the latest master (`5504d9259d59bb80e019ed1563b213dcf56fc86a`) I realized some unexpected crash on running the `conformance2 wpt tests`. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related. Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `00ac44796667d93806b79f79e23dcd4dcee58652` commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7 ``` Ran 1110 tests finished in 123.0 seconds. • 1107 ran as expected. 921 tests skipped. • 3 tests timed out unexpectedly ``` Running the `./mach test-wpt tests/wpt/webgl/tests/conformance2/` on the `5504d9259d59bb80e019ed1563b213dcf56fc86a` commit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23 ``` Ran 1110 tests finished in 136.0 seconds. • 1098 ran as expected. 921 tests skipped. • 1 tests crashed unexpectedly • 1 tests had errors unexpectedly • 6 tests timed out unexpectedly • 1 tests unexpectedly okay • 5 tests had unexpected subtest results ``` Additional information about my config: ``` OS: Manjaro Linux x86_64 Kernel: 5.4.34-1-MANJARO DE: Plasma CPU: AMD Ryzen 7 1800X (16) @ 3.600GHz GPU: NVIDIA GeForce GTX 1050 Ti ``` glxinfo | grep "OpenGL" : ``` OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GTX 1050 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 440.82 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 4.6.0 NVIDIA 440.82 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 440.82 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20 ``` Mesa version: `20.0.4-2` https://www.archlinux.org/packages/extra/x86_64/mesa/ Could the mesa or video driver downgrade/upgrade help on matching the results? --- Should I update the test expectations on an earlier commit or try on the master? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> cc @mmatyas @zakorgy @jdm
Contributor
|
💔 Test failed - status-taskcluster |
Contributor
|
☔ The latest upstream changes (presumably #26023) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
We're going to need to disable /_webgl/conformance2/renderbuffers/multisampled-depth-renderbuffer-initialization.html, /_webgl/conformance2/renderbuffers/multisampled-renderbuffer-initialization.html, and /_webgl/conformance2/renderbuffers/multisampled-stencil-renderbuffer-initialization.html on macOS. |
Member
|
Rebased in #26389. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial support for the WebGL2
BlitFramebuffercall.Note:
After I've rebased my patch to the latest master (
5504d9259d59bb80e019ed1563b213dcf56fc86a) I realized some unexpected crash on running theconformance2 wpt tests. I've talked with @mmatyas and the crashes did not appear on him side, maybe it could be driver related.Running the
./mach test-wpt tests/wpt/webgl/tests/conformance2/on the00ac44796667d93806b79f79e23dcd4dcee58652commit (before the #25853 Pull Request) the results: https://gist.github.com/imiklos/315078ddff683d74c5981258b2752aa7Running the
./mach test-wpt tests/wpt/webgl/tests/conformance2/on the5504d9259d59bb80e019ed1563b213dcf56fc86acommit (latest master) the results: https://gist.github.com/imiklos/6d8901975101d3a1720b911bfdc26e23Additional information about my config:
glxinfo | grep "OpenGL" :
Mesa version:
20.0.4-2https://www.archlinux.org/packages/extra/x86_64/mesa/Could the mesa or video driver downgrade/upgrade help on matching the results?
Should I update the test expectations on an earlier commit or try on the master?
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorscc @mmatyas @zakorgy @jdm