Merged
Conversation
highfive
added
the
S-awaiting-review
jdm
approved these changes
Jun 17, 2020
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
Greta work! I was worried the JSON code in C++ would be complex, but the client code is actually surprisingly readable!
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit e4041e0 has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
added a commit
that referenced
this pull request
Jun 17, 2020
[UWP] Basic console panel This PR introduces a Devtools client module to the UWP app. And a basic console panel. There are still bugs and missing features, that I will address in future PRs: - the output is just some text. No colors or formatting. This will be implemented as a [gridview](https://docs.microsoft.com/en-us/dotnet/framework/wpf/controls/gridview-overview) later. - When connecting to the devtools server, we get a prompt asking for permission. I see 2 options: we share the socket between Servo and the UWP app (no idea if that's actually possible) or we keep using the TCP transport and share a token between Servo and the UWP app that would allow to bypass the permission prompt - add a JS input. - show HTTP errors. For now they are just ignored. - There are 3 panels now: console, preference and a random "devtool server" panel that shows the devtools port. We could just print the port number in the console instead. - Servo crashes if we open the devtools too early. This needs investigation. Also, now that we have the foundation of a devtools client in UWP, we should remove the recently introduced preference API and rely on the preference devtools actor instead. Fix #26850
Contributor
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
Member
|
highfive
added
S-awaiting-review
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit bd8c7d6 has been approved by |
highfive
added
S-awaiting-merge
highfive
added
S-awaiting-review
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit c7f5d8a has been approved by |
highfive
added
S-awaiting-merge
Contributor
Contributor
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
5 tasks
Member
|
@RaananW As of today's nightly, you can now pop open a panel in Firefox Reality that shows the console messages and JS exceptions for the current page. It's the default view when clicking the wrench button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Devtools client module to the UWP app. And a basic console panel.
There are still bugs and missing features, that I will address in future PRs:
the output is just some text. No colors or formatting. This will be implemented as a gridview later.When connecting to the devtools server, we get a prompt asking for permission. I see 2 options: we share the socket between Servo and the UWP app (no idea if that's actually possible) or we keep using the TCP transport and share a token between Servo and the UWP app that would allow to bypass the permission promptadd a JS input.There are 3 panels now: console, preference and a random "devtool server" panel that shows the devtools port. We could just print the port number in the console instead.Servo crashes if we open the devtools too early. This needs investigation.Also, now that we have the foundation of a devtools client in UWP, we should remove the recently introduced preference API and rely on the preference devtools actor instead.
Fix #26850