compositing: Send CompositorDisplayListInfo as bytes to compositor#36484
Merged
mrobinson merged 1 commit intoservo:mainfrom Apr 12, 2025
Merged
compositing: Send CompositorDisplayListInfo as bytes to compositor#36484mrobinson merged 1 commit intoservo:mainfrom
CompositorDisplayListInfo as bytes to compositor#36484mrobinson merged 1 commit intoservo:mainfrom
Conversation
`CompositorDisplayListInfo` is a large data structure that scales with the size of the display list. Serializing it onto the Compositor's IPC channel can cause deadlocks. This change serializes it with bincode and sends it alongside the rest of the serialized display list information on the IPC `bytes_channel`. This should prevent deadlocks when the compositor API is unified. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
|
🔨 Triggering try run (#14419634449) for Linux (WPT) |
|
Test results for linux-wpt from try job (#14419634449): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#14419634449) succeeded. |
Member
|
Can you explain the source of the deadlock? I'm having trouble following. |
Member
Author
|
Here's what I think is happening, and I believe that there are three threads involved:
I think the main issue here is that |
Member
Author
|
Apologies for not including the details earlier. Let me know if you need more information. I'm happy to keep digging if something is missing! |
Member
Author
|
Ah, I forgot to mention that this is an issue because before, I believe that the router thread was buffering and blocking before, rather than the scene builder thread. #36443 removes the router thread from the mix and removes the extra buffering and copying. |
Member
|
Oof! |
jdm
approved these changes
Apr 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompositorDisplayListInfois a large data structure that scales withthe size of the display list. Serializing it onto the Compositor's IPC
channel can cause deadlocks. This change serializes it with bincode and
sends it alongside the rest of the serialized display list information
on the IPC
bytes_channel. This should prevent deadlocks when thecompositor API is unified.
Testing: This is covered by existing WPT tests.
Signed-off-by: Martin Robinson mrobinson@igalia.com