compositing: Make RefreshDriver per-RenderingContext
#40738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a global `RefreshDriver` for all of Servo, let each `RenderingContext` have its own `RefreshDriver`. This allows for things like per-monitor `RefreshDriver`s and helps to ensure that multiple `BaseRefreshDriver`s can be created for the same `RefreshDriver`. Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
jdm
approved these changes
Nov 19, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
servo-highfive
added
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a global
RefreshDriverfor all of Servo, let eachRenderingContexthave its ownRefreshDriver. This allows for thingslike per-monitor
RefreshDrivers and helps to ensure that multipleBaseRefreshDrivers can be created for the sameRefreshDriver.Testing: This shouldn't change behavior and thus is covered by existing tests.