webdriver: Implement pointerCancel for touch chain#41937
Merged
yezhizhen merged 6 commits intoservo:mainfrom Jan 17, 2026
Merged
webdriver: Implement pointerCancel for touch chain#41937yezhizhen merged 6 commits intoservo:mainfrom
yezhizhen merged 6 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57196) with upstreamable changes. |
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
c2b59e7 to
3febd21
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
TimvdLippe
approved these changes
Jan 16, 2026
servo-highfive
added
S-awaiting-review
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
81aaf96 to
3c5d101
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
3c5d101 to
23ca020
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
23ca020 to
9e70cb4
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
jdm
approved these changes
Jan 16, 2026
tests/wpt/tests/webdriver/tests/classic/perform_actions/pointer_touch.py
Outdated
Show resolved
Hide resolved
servo-highfive
removed
the
S-awaiting-review
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
9e70cb4 to
2895485
Compare
servo-highfive
added
the
S-awaiting-review
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
2895485 to
959ecb4
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57196) title and body. |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
yezhizhen
commented
Jan 17, 2026
tests/wpt/tests/webdriver/tests/classic/perform_actions/pointer_touch.py
Show resolved
Hide resolved
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
yezhizhen
force-pushed
the
pointercancel-touch
branch
from
959ecb4 to
0af40bd
Compare
servo-highfive
removed
the
S-tests-failed
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
1 similar comment
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57196). |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57196) title and body. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 20, 2026
…chend`/`touchcancel` (servo#42654) [Spec](https://w3c.github.io/touch-events/#dfn-touchend:~:text=screen%2E-,The,element,-%2E) for touchmove/touchend/touchcancel: > The target of this event must be the same Element on which the [touch point](https://w3c.github.io/touch-events/#dfn-touch-point) started when it was first placed on the surface, even if the [touch point](https://w3c.github.io/touch-events/#dfn-touch-point) has since moved outside the interactive area of the target element. Also, previously `touchend` can be fired after `touchcancel`, which was wrong and fixed in this PR. Testing: Fully passes `/touch-events/multi-touch-interfaces.html` (511 subtests) and new passes in `pointerevents\compat\pointerevent_touch_target_after_pointerdown_target_removed.tentative.html`. We also take the chance to update `pointercancel` related tests introduced in servo#41937: `touchcancel` should not be followed by `touchend` according to [spec](https://w3c.github.io/touch-events/#dfn-touchcancel). --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Adding a new function
pointer_cancelin test infrastructure and two touch chain subtests for pointerCancel.