script: Fix handling of invalid fetch responses for link stylesheets#42037
script: Fix handling of invalid fetch responses for link stylesheets#42037TimvdLippe merged 3 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#21184270128) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21184270128): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (12)
|
|
|
d078603 to
6912a4f
Compare
|
🔨 Triggering try run (#21207706910) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21207706910): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (32)
Stable unexpected results (8)
|
|
|
6912a4f to
31f7c35
Compare
|
🔨 Triggering try run (#21212680501) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21212680501): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#21212680501) succeeded. |
...s/wpt/meta/html/semantics/document-metadata/the-link-element/link-load-error-events.html.ini
Outdated
Show resolved
Hide resolved
TimvdLippe
left a comment
There was a problem hiding this comment.
Seems like I never clicked on "sent" 🫢
...s/wpt/meta/html/semantics/document-metadata/the-link-element/link-load-error-events.html.ini
Outdated
Show resolved
Hide resolved
...meta/html/semantics/document-metadata/the-link-element/link-load-error-events.https.html.ini
Outdated
Show resolved
Hide resolved
...wpt/meta/html/semantics/document-metadata/the-link-element/stylesheet-non-OK-status.html.ini
Outdated
Show resolved
Hide resolved
31f7c35 to
c4de451
Compare
| expected: FAIL | ||
|
|
||
| [Stylesheet loading using @import with wrong Content-Type, same-origin, and nosniff] | ||
| expected: FAIL |
There was a problem hiding this comment.
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//" ""> | |||
| <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> | |||
There was a problem hiding this comment.
Per whatwg/html#12097 (comment) Copied the value from tests/wpt/tests/quirks/line-height-limited-quirks-mode.html
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57295) with upstreamable changes. |
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of servo#22715 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
c4de451 to
ee86dc6
Compare
|
🔨 Triggering try run (#21256381552) for Linux (WPT) |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57295). |
|
Test results for linux-wpt from try job (#21256381552): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#21256381552) succeeded. |
Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57295). |
1 similar comment
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57295). |
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
7faad1f to
6b05068
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57295). |
Regardless of the
Okstatus, we should always create astylesheet. However, the determining of the load/error event
is based on whether it has parsed actual content or not.
It also realigns some of the spec text to now only do it for link
elements, since for styles we shouldn't be checking the result of
the content type.
Part of #22715